Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@elta.co.il>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/doco] add obstacks to gdbint.texi
Date: Tue, 10 Feb 2004 19:04:00 -0000	[thread overview]
Message-ID: <6654-Tue10Feb2004210510+0200-eliz@elta.co.il> (raw)
In-Reply-To: <16425.5280.824503.7068@localhost.redhat.com> (message from Elena Zannoni on Tue, 10 Feb 2004 12:28:00 -0500)

> From: Elena Zannoni <ezannoni@redhat.com>
> Date: Tue, 10 Feb 2004 12:28:00 -0500
> 
> Eli, I am sure it's not perfect.

Actually, it's quite close.

> How do I quote function names, for instance?

Any programming-language symbol should have the @code markup:
@code{xmalloc}, @code{xrealloc}, etc.

> +@cindex libiberty library
> +
> +The libiberty library provides a set of functions and features that

"libiberty" is (almost) a file name, so it should be in @file, both in
the index entry and in the text.

> +@value{GDBN} uses various features provided by the libiberty library,
> +for instance the memory management functions xfree and xmalloc, and
> +the obstack extension.

I would put "obstack" either in @code or in @samp.

> +@subsection obstacks in @value{GDBN}

Please add a @cindex entry here so that people could find the info
about obstacks quickly.

> +a stack. Objects (of any nature, size and alignment) are allocated and
> +freed in a LIFO fashion on an obstack. (See the libiberty's

"LIFO" is an acronym, so it's better to say "@acronym{LIFO}"; the
result after typesetting by TeX will look prettier.

Finally, there are many places where there's only one blank after a
dot that ends a sentence.  Please make that 2 spaces.

Last, but certainly not least, thanks for taking time to write this.


  reply	other threads:[~2004-02-10 19:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-10 17:31 Elena Zannoni
2004-02-10 19:04 ` Eli Zaretskii [this message]
2004-02-10 19:51   ` Elena Zannoni
2004-02-10 20:06     ` Eli Zaretskii
2004-02-10 20:38       ` Elena Zannoni
2004-02-11  6:09         ` Eli Zaretskii
2004-02-11 15:41           ` Elena Zannoni
2004-02-11 19:27             ` Eli Zaretskii
2004-02-10 19:30 ` Daniel Jacobowitz
2004-02-10 20:06   ` Elena Zannoni
2004-02-10 20:11     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6654-Tue10Feb2004210510+0200-eliz@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox