From: Pedro Alves <palves@redhat.com>
To: John Baldwin <jhb@FreeBSD.org>,
gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH 3/6] Fetch the ELF auxiliary vector from live processes on FreeBSD.
Date: Mon, 20 Jun 2016 23:01:00 -0000 [thread overview]
Message-ID: <6619a049-91bf-a76b-a28e-7c73ef29e957@redhat.com> (raw)
In-Reply-To: <20160616060202.63470-4-jhb@FreeBSD.org>
On 06/16/2016 07:01 AM, John Baldwin wrote:
> +static enum target_xfer_status
> +fbsd_xfer_partial (struct target_ops *ops, enum target_object object,
"Implement foo"-style intro comment missing.
> + switch (object)
> + {
> + case TARGET_OBJECT_AUXV:
> + {
> + struct cleanup *cleanup = make_cleanup (null_cleanup, NULL);
> + unsigned char *buf;
> + size_t buflen;
> + int mib[4];
> +
> + if (writebuf)
writebuf != NULL.
Otherwise LGTM.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-06-20 23:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 6:02 [PATCH 0/6] Add ELF auxiliary vector handling for FreeBSD John Baldwin
2016-06-16 6:02 ` [PATCH 2/6] Add elfcore_grok_freebsd_note to parse FreeBSD ELF core notes John Baldwin
2016-06-17 8:28 ` Nick Clifton
2016-06-16 6:02 ` [PATCH 3/6] Fetch the ELF auxiliary vector from live processes on FreeBSD John Baldwin
2016-06-20 23:01 ` Pedro Alves [this message]
2016-06-16 6:02 ` [PATCH 1/6] Add constants for FreeBSD-specific auxiliary vector entry types John Baldwin
2016-06-17 8:27 ` Nick Clifton
2016-06-16 6:02 ` [PATCH 6/6] Add a gdbarch 'print_auxv' method for FreeBSD ABIs John Baldwin
2016-06-20 23:43 ` Pedro Alves
2016-06-16 6:11 ` [PATCH 5/6] Add a new gdbarch method to print a single AUXV entry John Baldwin
2016-06-20 23:40 ` Pedro Alves
2016-06-23 20:19 ` John Baldwin
2016-06-16 6:11 ` [PATCH 4/6] Create a psuedo section for the ELF AUXV core dump note on FreeBSD John Baldwin
2016-06-17 8:28 ` Nick Clifton
2016-06-20 23:45 ` Pedro Alves
2016-06-20 17:10 ` [PATCH 0/6] Add ELF auxiliary vector handling for FreeBSD John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6619a049-91bf-a76b-a28e-7c73ef29e957@redhat.com \
--to=palves@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox