From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-132197-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 119815 invoked by alias); 20 Jun 2016 23:01:53 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 119794 invoked by uid 89); 20 Jun 2016 23:01:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 20 Jun 2016 23:01:46 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id CC5FA63E0A;	Mon, 20 Jun 2016 23:01:44 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5KN1hd3017769;	Mon, 20 Jun 2016 19:01:44 -0400
Subject: Re: [PATCH 3/6] Fetch the ELF auxiliary vector from live processes on FreeBSD.
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org,        binutils@sourceware.org
References: <20160616060202.63470-1-jhb@FreeBSD.org> <20160616060202.63470-4-jhb@FreeBSD.org>
From: Pedro Alves <palves@redhat.com>
Message-ID: <6619a049-91bf-a76b-a28e-7c73ef29e957@redhat.com>
Date: Mon, 20 Jun 2016 23:01:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <20160616060202.63470-4-jhb@FreeBSD.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-06/txt/msg00341.txt.bz2

On 06/16/2016 07:01 AM, John Baldwin wrote:

> +static enum target_xfer_status
> +fbsd_xfer_partial (struct target_ops *ops, enum target_object object,

"Implement foo"-style intro comment missing.

> +  switch (object)
> +    {
> +    case TARGET_OBJECT_AUXV:
> +      {
> +	struct cleanup *cleanup = make_cleanup (null_cleanup, NULL);
> +	unsigned char *buf;
> +	size_t buflen;
> +	int mib[4];
> +
> +	if (writebuf)

writebuf != NULL.

Otherwise LGTM.

Thanks,
Pedro Alves