Re: [PATCH 0/2] [gdb] TSAN fixes

[Tom de Vries <tdevries@suse.de>]

On 5/27/26 9:02 PM, Tom de Vries wrote:
> I build gdb with TSAN at -O0, ran the testsuite and found a few problems.
> 
> This series fixes those.
> 
> The first patch is a refactoring patch.
> 
> The second patch removes a local lock in try_open_dwop_file.
>

I forgot to mention: this is v3.

Thanks,
- Tom


> Changes since v1:
> - commited an approved patch [1]
> - combined two patches related to the local lock in try_open_dwop_file
> - replaced last patch by new patch changing the locking scheme
> 
> Changes since v2:
> - committed another approved patch [2]
> - use gdb_bfd_check_format consistently instead of just once
> - add gdb_bfd_check_format_matches, addressing the same issue as for
>    gdb_bfd_check_format
> - factor out refactoring patch, to make it easier to review
> 
> [1] https://sourceware.org/pipermail/gdb-patches/2026-January/224422.html
> [2] https://sourceware.org/pipermail/gdb-patches/2026-February/225028.html
> 
> Versions:
> - v1 https://sourceware.org/pipermail/gdb-patches/2026-January/224424.html
> - v2 https://sourceware.org/pipermail/gdb-patches/2026-February/225027.html
> 
> Tom de Vries (2):
>    [gdb] Add gdb_bfd_check_format and gdb_bfd_check_format_matches
>    [gdb/symtab] Fix data race in try_open_dwop_file
> 
>   gdb/build-id.c                    |  4 ++--
>   gdb/cli/cli-dump.c                |  2 +-
>   gdb/compile/compile-object-load.c |  2 +-
>   gdb/corelow.c                     |  8 ++++----
>   gdb/dwarf2/dwz.c                  |  2 +-
>   gdb/dwarf2/read.c                 | 15 ++++-----------
>   gdb/exec.c                        |  2 +-
>   gdb/gdb_bfd.c                     | 24 ++++++++++++++++++++++--
>   gdb/gdb_bfd.h                     | 11 ++++++++++-
>   gdb/i386-darwin-tdep.c            |  2 +-
>   gdb/jit.c                         |  2 +-
>   gdb/machoread.c                   |  6 +++---
>   gdb/minidebug.c                   |  2 +-
>   gdb/solib-aix.c                   |  6 +++---
>   gdb/solib-rocm.c                  |  2 +-
>   gdb/solib.c                       |  4 ++--
>   gdb/symfile-mem.c                 |  2 +-
>   gdb/symfile.c                     |  6 +++---
>   gdb/windows-nat.c                 |  2 +-
>   19 files changed, 63 insertions(+), 41 deletions(-)
> 
> 
> base-commit: d623dadc2c4ecd509359015ae5a1ac856ba89b05