From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QQtJJUhAF2pH5iAAWB0awg (envelope-from ) for ; Wed, 27 May 2026 15:04:40 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ahqQqjj1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=I2LZFsHX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ahqQqjj1; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=I2LZFsHX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 936971E024; Wed, 27 May 2026 15:04:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 20EDA1E024 for ; Wed, 27 May 2026 15:04:40 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 45A364BA2E29 for ; Wed, 27 May 2026 19:04:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 45A364BA2E29 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ahqQqjj1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=I2LZFsHX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ahqQqjj1; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=I2LZFsHX Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 1E89E4BA2E39 for ; Wed, 27 May 2026 19:03:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E89E4BA2E39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E89E4BA2E39 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779908623; cv=none; b=kieSHzhGNvuKitDi86L+SOrQ2swnk1nCLc1ujIB1/3dF/7bxND6O/7EwGTQNZ358B7CSd7x2O1byOYaJB2yM58ByAVkLi9GE8Ub9Jxq4a0BD5ratin2kN5EPRgD3osmDwg5Oce4ddjOC0iViTLLNVXTSCas034FEf5LeYVo/y+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779908623; c=relaxed/simple; bh=bOq2p50qPERWOi2z4QjFtA66cHtGOsdVfwgjIXIEfcg=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=LRsHc85syDTRiss5q4Yuq1FL1AXT0U+0fzpMWc26IoaDp6K63DeJrFB0liVTM2Hhvo6LlT143cNdTfgW/1eIDUxSnt7A0Nf4ggwlwYmg42b/KgmXP2lwma/FJIV5srCq5uqbJEp1qJi6e6NDD278P7NbwGA6935BquAeIYAvR+k= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ahqQqjj1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=I2LZFsHX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ahqQqjj1; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=I2LZFsHX DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1E89E4BA2E39 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 855B866FF3 for ; Wed, 27 May 2026 19:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779908621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E9rD/YjjV7htjE8WEgNACU7LTd0iQmpNeER3ytRnowY=; b=ahqQqjj1BUNjMqCpZtYyIy1ggBBCg0Qtic1zs11+89b9FZeslybxvV/0aR9SxsWdAErhJY EEOFkI0tgHyn5UBiEXMj8yUe66WvNDbhjJ+VnO6cSGA0JJ8VXrUdj58IYJbOXFsN8as/2q jYw2Xc9DkcJabV+LI4UixR0kWUH1Rgg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779908621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E9rD/YjjV7htjE8WEgNACU7LTd0iQmpNeER3ytRnowY=; b=I2LZFsHXRIS7eHjUDU+k42E0Qphhes8+FzB5hkpyqYRn63VN/mlOigFKxQOGlvkGvL2iZn L0e8+VLtWyvr54CA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ahqQqjj1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=I2LZFsHX DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779908621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E9rD/YjjV7htjE8WEgNACU7LTd0iQmpNeER3ytRnowY=; b=ahqQqjj1BUNjMqCpZtYyIy1ggBBCg0Qtic1zs11+89b9FZeslybxvV/0aR9SxsWdAErhJY EEOFkI0tgHyn5UBiEXMj8yUe66WvNDbhjJ+VnO6cSGA0JJ8VXrUdj58IYJbOXFsN8as/2q jYw2Xc9DkcJabV+LI4UixR0kWUH1Rgg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779908621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E9rD/YjjV7htjE8WEgNACU7LTd0iQmpNeER3ytRnowY=; b=I2LZFsHXRIS7eHjUDU+k42E0Qphhes8+FzB5hkpyqYRn63VN/mlOigFKxQOGlvkGvL2iZn L0e8+VLtWyvr54CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 748FA5A995 for ; Wed, 27 May 2026 19:03:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Qw0aGw1AF2pudwAAD6G6ig (envelope-from ) for ; Wed, 27 May 2026 19:03:41 +0000 Message-ID: <65d83245-c98e-457d-9a2e-c86ae2de3b49@suse.de> Date: Wed, 27 May 2026 21:03:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] [gdb] TSAN fixes From: Tom de Vries To: gdb-patches@sourceware.org References: <20260527190228.3656310-1-tdevries@suse.de> Content-Language: en-US In-Reply-To: <20260527190228.3656310-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 855B866FF3 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url,suse.de:dkim,suse.de:mid]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/27/26 9:02 PM, Tom de Vries wrote: > I build gdb with TSAN at -O0, ran the testsuite and found a few problems. > > This series fixes those. > > The first patch is a refactoring patch. > > The second patch removes a local lock in try_open_dwop_file. > I forgot to mention: this is v3. Thanks, - Tom > Changes since v1: > - commited an approved patch [1] > - combined two patches related to the local lock in try_open_dwop_file > - replaced last patch by new patch changing the locking scheme > > Changes since v2: > - committed another approved patch [2] > - use gdb_bfd_check_format consistently instead of just once > - add gdb_bfd_check_format_matches, addressing the same issue as for > gdb_bfd_check_format > - factor out refactoring patch, to make it easier to review > > [1] https://sourceware.org/pipermail/gdb-patches/2026-January/224422.html > [2] https://sourceware.org/pipermail/gdb-patches/2026-February/225028.html > > Versions: > - v1 https://sourceware.org/pipermail/gdb-patches/2026-January/224424.html > - v2 https://sourceware.org/pipermail/gdb-patches/2026-February/225027.html > > Tom de Vries (2): > [gdb] Add gdb_bfd_check_format and gdb_bfd_check_format_matches > [gdb/symtab] Fix data race in try_open_dwop_file > > gdb/build-id.c | 4 ++-- > gdb/cli/cli-dump.c | 2 +- > gdb/compile/compile-object-load.c | 2 +- > gdb/corelow.c | 8 ++++---- > gdb/dwarf2/dwz.c | 2 +- > gdb/dwarf2/read.c | 15 ++++----------- > gdb/exec.c | 2 +- > gdb/gdb_bfd.c | 24 ++++++++++++++++++++++-- > gdb/gdb_bfd.h | 11 ++++++++++- > gdb/i386-darwin-tdep.c | 2 +- > gdb/jit.c | 2 +- > gdb/machoread.c | 6 +++--- > gdb/minidebug.c | 2 +- > gdb/solib-aix.c | 6 +++--- > gdb/solib-rocm.c | 2 +- > gdb/solib.c | 4 ++-- > gdb/symfile-mem.c | 2 +- > gdb/symfile.c | 6 +++--- > gdb/windows-nat.c | 2 +- > 19 files changed, 63 insertions(+), 41 deletions(-) > > > base-commit: d623dadc2c4ecd509359015ae5a1ac856ba89b05