From: Simon Marchi <simon.marchi@polymtl.ca>
To: Lancelot SIX <lancelot.six@amd.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb/amd-dbgapi: add basic watchpoint support
Date: Thu, 5 Feb 2026 13:54:18 -0500 [thread overview]
Message-ID: <6511d328-697a-45a5-9700-5badeedcca2b@polymtl.ca> (raw)
In-Reply-To: <gvvkzaxpswsa2cwoz753jqrupgczs5td3kpqz6tgja6pkmb34m@kmxxxhzq6ym5>
On 2/4/26 3:33 PM, Lancelot SIX wrote:
> Might be worth adding Laurent as co-auther, he did the initial
> implementation of this patch.
>
> With that, this looks good to me. I have tested it against the
> downstream testsuite as well, no issue reported there.
>
> Best,
> Lancelot.
>
> Approved-by: Lancelot Six <lancelot.six@amd.com>
Done and pushed, thanks.
Simon
next prev parent reply other threads:[~2026-02-05 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-24 5:14 [PATCH 1/2] gdb/testsuite: add rocm-test-utils.h simon.marchi
2026-01-24 5:15 ` [PATCH 2/2] gdb/amd-dbgapi: add basic watchpoint support simon.marchi
2026-02-04 20:33 ` Lancelot SIX
2026-02-05 18:54 ` Simon Marchi [this message]
2026-02-04 18:39 ` [PATCH 1/2] gdb/testsuite: add rocm-test-utils.h Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6511d328-697a-45a5-9700-5badeedcca2b@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox