From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AeWTMYTnhGn/HCoAWB0awg (envelope-from ) for ; Thu, 05 Feb 2026 13:55:00 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=PbiMGjUE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C68C81E0BA; Thu, 05 Feb 2026 13:55:00 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F0BF21E08D for ; Thu, 05 Feb 2026 13:54:59 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 8CF414B92083 for ; Thu, 5 Feb 2026 18:54:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8CF414B92083 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=PbiMGjUE Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8DD8C4BB3B9C for ; Thu, 5 Feb 2026 18:54:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8DD8C4BB3B9C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8DD8C4BB3B9C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770317666; cv=none; b=qmpW3YgKeiOTGVddt1KkcW85tAXLDsZDdeko2K9cSPPKcB534IynqsMe9fTVTEfg+G5Dh3SRbMrjvVjQLi/Ad6g2c28jiTY9EMrtZ6K6URoJsUBhXIjw5B0lT4XymGcfLCYOunA13sFCAuORBSb7SAzEWyd0IsO+Vx8IlypYZBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770317666; c=relaxed/simple; bh=ijv9jk3H9W//seLKvUN3q6itAsCzsff3MvpqgUtLNWM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vpOYF1056AxW5YlIbi3uZBWsoqEgsYzjL9iR+eHQqEyTBFhvLIfKS6a68lcn+irER1eP4xVEjaPFL8VS0EYxk9uugJ0KKq0WprCiBRDyczHgTsj4+WSCA+RI3xtHD4dbm2XAM5dC9h7PsjDenBLViy+4SC1XaQXv3BmnGha0kzw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8DD8C4BB3B9C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 615IsIc0185400 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Feb 2026 13:54:23 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 615IsIc0185400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1770317663; bh=6WjwgvnBzapHYLzkac5770IDBZ1opGIOdrYxeYEI35M=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=PbiMGjUEy1C/xhh4zU+gy4YbASIdr68x49SEojhOaMKQNWEaLpFEB+s3SEHkXCL2r nYJRPYWYyQbW8gnMRjrJnpgWFO12e0HZkdtszjoQLVLtp6rpgAkxJ+scPwLEogPQjA ms9GnswkJOZOMY1nHMeKQ5sCsJhn0zUzam3+QP5c+YOX1Om/n6YEOgjkLf4BM9Rwye VbPKvHKLM9JC3bRJzmSv8g1HrxpXuPThYoBCc1pCdW1CH7mHmEPcJNs5Bnz+ue6xkN ig4qG/619jmjyqnsiVIT1VBsEsKoZhXj3A0vNhAGfgN67UXnrIaXmVXTb0DyrHVk95 COSqMKMSMGY8Q== Received: by simark.ca (Postfix) id 71FA01E08D; Thu, 05 Feb 2026 13:54:18 -0500 (EST) Message-ID: <6511d328-697a-45a5-9700-5badeedcca2b@polymtl.ca> Date: Thu, 5 Feb 2026 13:54:18 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb/amd-dbgapi: add basic watchpoint support To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20260124051512.731-2-simon.marchi@polymtl.ca> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 5 Feb 2026 18:54:18 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/4/26 3:33 PM, Lancelot SIX wrote: > Might be worth adding Laurent as co-auther, he did the initial > implementation of this patch. > > With that, this looks good to me. I have tested it against the > downstream testsuite as well, no issue reported there. > > Best, > Lancelot. > > Approved-by: Lancelot Six Done and pushed, thanks. Simon