Re: [PATCH][gdb/tdep] Detect get_pc_thunk call in i386 prologue

[Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>]

On 5/30/22 14:10, Tom de Vries wrote:
> Fix the regressions by updating the test-cases to accept the new output.

These regressions were those that I ran into with a first version of the 
patch, which handled only __x86.get_pc_thunk.ax.

This version handles bx and dx in addition, which triggers an additional 
regression (indeed another -O2 test-case):
...
FAIL: gdb.cp/step-and-next-inline.exp: no_header: not in inline 1
...

Anyway, a quick investigation shows that there are still more regs to 
handle:
...
$ objdump -d /lib/libc.so.6 | grep get_pc_thunk | awk '{print $9}' | sort -u

<__x86.get_pc_thunk.ax>
<__x86.get_pc_thunk.bp>
<__x86.get_pc_thunk.bx>
<__x86.get_pc_thunk.cx>
<__x86.get_pc_thunk.di>
<__x86.get_pc_thunk.dx>
<__x86.get_pc_thunk.si>
...
so with a more complete version of this patch, still more -O2 
regressions may show up.

Thanks,
- Tom