From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FiezN1hooGKLlQAAWB0awg (envelope-from ) for ; Wed, 08 Jun 2022 05:14:00 -0400 Received: by simark.ca (Postfix, from userid 112) id CF38B1E223; Wed, 8 Jun 2022 05:14:00 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=k9VZwHMT; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 78AC21E15C for ; Wed, 8 Jun 2022 05:14:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C6CE93853547 for ; Wed, 8 Jun 2022 09:13:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C6CE93853547 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1654679638; bh=vs8SDwhLl1E/046RBsPEzO1/1oXqp0XwbUVGjxDVCsA=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=k9VZwHMTHQLWyTKf/KQrMDajh/TCqfwVK2YFliBXEb6HTybfNKp0VtpRWk17cLzxH Et0/hqoY1SDe0pNnQCSXky1G6bCWcqtbtDRzai6OgogE8hEg/FTmAqQjVPDjn0Wdf/ Ynq3CQTuJ+QudEaQ8VKBVPUh5MXCdJ+wdPznu41I= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 59522383F96E for ; Wed, 8 Jun 2022 09:13:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 59522383F96E Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 76D5021B8D for ; Wed, 8 Jun 2022 09:13:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6696F13A15 for ; Wed, 8 Jun 2022 09:13:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id z8LRFzxooGKOVwAAMHmgww (envelope-from ) for ; Wed, 08 Jun 2022 09:13:32 +0000 Message-ID: <64d3f391-f323-eaed-0504-927fde10fb7a@suse.de> Date: Wed, 8 Jun 2022 11:13:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH][gdb/tdep] Detect get_pc_thunk call in i386 prologue Content-Language: en-US To: gdb-patches@sourceware.org References: <20220530121003.GA16697@delia.home> In-Reply-To: <20220530121003.GA16697@delia.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 5/30/22 14:10, Tom de Vries wrote: > Fix the regressions by updating the test-cases to accept the new output. These regressions were those that I ran into with a first version of the patch, which handled only __x86.get_pc_thunk.ax. This version handles bx and dx in addition, which triggers an additional regression (indeed another -O2 test-case): ... FAIL: gdb.cp/step-and-next-inline.exp: no_header: not in inline 1 ... Anyway, a quick investigation shows that there are still more regs to handle: ... $ objdump -d /lib/libc.so.6 | grep get_pc_thunk | awk '{print $9}' | sort -u <__x86.get_pc_thunk.ax> <__x86.get_pc_thunk.bp> <__x86.get_pc_thunk.bx> <__x86.get_pc_thunk.cx> <__x86.get_pc_thunk.di> <__x86.get_pc_thunk.dx> <__x86.get_pc_thunk.si> ... so with a more complete version of this patch, still more -O2 regressions may show up. Thanks, - Tom