From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb: remove HAVE_DECL_PTRACE
Date: Fri, 20 Mar 2020 12:06:00 -0400 [thread overview]
Message-ID: <647a6d40-76e9-a8c4-17b5-8978fe2cfbf7@simark.ca> (raw)
In-Reply-To: <87lfnvkon9.fsf@tromey.com>
On 2020-03-20 11:54 a.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> I stumbled on this snippet in nat/gdb_ptrace.h:
> Simon> /* Some systems, in particular DEC OSF/1, Digital Unix, Compaq Tru64
> Simon> or whatever it's called these days, don't provide a prototype for
> Simon> ptrace. Provide one to silence compiler warnings. */
>
> Simon> #ifndef HAVE_DECL_PTRACE
> Simon> extern PTRACE_TYPE_RET ptrace();
> Simon> #endif
>
> Simon> I believe this is unnecessary today and should be removed. First, the
> Simon> comment only mentions OSes we don't support (and to be honest, I had
> Simon> never even heard of).
>
> Thanks, this looks good to me.
>
> Tom
>
Thanks, I pushed it.
Simon
prev parent reply other threads:[~2020-03-20 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 15:27 Simon Marchi
2020-03-20 15:54 ` Tom Tromey
2020-03-20 16:06 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=647a6d40-76e9-a8c4-17b5-8978fe2cfbf7@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox