From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id E41EF393FC3D
 for <gdb-patches@sourceware.org>; Fri, 20 Mar 2020 16:06:01 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E41EF393FC3D
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net
 [192.222.181.218])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 5812A1E092;
 Fri, 20 Mar 2020 12:06:01 -0400 (EDT)
Subject: Re: [PATCH] gdb: remove HAVE_DECL_PTRACE
To: Tom Tromey <tom@tromey.com>,
 Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
References: <20200319152742.2495-1-simon.marchi@efficios.com>
 <87lfnvkon9.fsf@tromey.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <647a6d40-76e9-a8c4-17b5-8978fe2cfbf7@simark.ca>
Date: Fri, 20 Mar 2020 12:06:00 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <87lfnvkon9.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <http://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Mar 2020 16:06:03 -0000

On 2020-03-20 11:54 a.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> I stumbled on this snippet in nat/gdb_ptrace.h:
> Simon>     /* Some systems, in particular DEC OSF/1, Digital Unix, Compaq Tru64
> Simon>        or whatever it's called these days, don't provide a prototype for
> Simon>        ptrace.  Provide one to silence compiler warnings.  */
> 
> Simon>     #ifndef HAVE_DECL_PTRACE
> Simon>     extern PTRACE_TYPE_RET ptrace();
> Simon>     #endif
> 
> Simon> I believe this is unnecessary today and should be removed.  First, the
> Simon> comment only mentions OSes we don't support (and to be honest, I had
> Simon> never even heard of).
> 
> Thanks, this looks good to me.
> 
> Tom
> 

Thanks, I pushed it.

Simon