From: Simon Marchi <simark@simark.ca>
To: gnutoolchain-gerrit@osci.io,
Christian Biesinger <cbiesinger@google.com>,
gdb-patches@sourceware.org
Subject: Re: [review] Simplify Python checks in configure.ac
Date: Thu, 24 Oct 2019 13:54:00 -0000 [thread overview]
Message-ID: <6384c0b9-824e-edcf-1086-1bc74cbc1a5b@simark.ca> (raw)
In-Reply-To: <20191024135237.E2ED0238BA@gnutoolchain-gerrit.osci.io>
On 2019-10-24 9:52 a.m., Simon Marchi (Code Review) wrote:
> Simon Marchi has posted comments on this change.
>
> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/241
> ......................................................................
>
>
> Patch Set 1:
>
> (1 comment)
>
> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/241/1/gdb/configure.ac
> File gdb/configure.ac:
>
> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/241/1/gdb/configure.ac@694
> PS1, Line 694: dnl $1 = the shell variable to assign the result to
> This is a test comment.
This is a test reply to the test comment.
Simon
next prev parent reply other threads:[~2019-10-24 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 22:04 Christian Biesinger (Code Review)
2019-10-24 13:44 ` Simon Marchi
2019-10-24 13:52 ` Simon Marchi (Code Review)
2019-10-24 13:54 ` Simon Marchi [this message]
2019-10-24 18:45 ` Tom Tromey (Code Review)
2019-10-24 18:48 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-24 18:48 ` Sourceware to Gerrit sync (Code Review)
2019-10-24 18:50 ` [review v2] " Christian Biesinger (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6384c0b9-824e-edcf-1086-1bc74cbc1a5b@simark.ca \
--to=simark@simark.ca \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox