From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@sourceware.org>,
Simon Marchi <simon.marchi@polymtl.ca>
Subject: [review v2] Simplify Python checks in configure.ac
Date: Thu, 24 Oct 2019 18:50:00 -0000 [thread overview]
Message-ID: <20191024185046.E80E4204C9@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571868251000.I07073870d9040c2bc8519882c8b3c1368edd4513@gnutoolchain-gerrit.osci.io>
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/241
......................................................................
Patch Set 2:
> Patch Set 1:
>
> Thanks, that LGTM.
>
> It seems like the `python_has_threads` stuff is unused too...
Oops, I did not see your comment. Yeah it looks like python_has_threads has been unused since 404f29021abaef86a341663444fb069eb1f0282a, I'll make a separate patch for that.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I07073870d9040c2bc8519882c8b3c1368edd4513
Gerrit-Change-Number: 241
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Thu, 24 Oct 2019 18:50:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
prev parent reply other threads:[~2019-10-24 18:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 22:04 [review] " Christian Biesinger (Code Review)
2019-10-24 13:44 ` Simon Marchi
2019-10-24 13:52 ` Simon Marchi (Code Review)
2019-10-24 13:54 ` Simon Marchi
2019-10-24 18:45 ` Tom Tromey (Code Review)
2019-10-24 18:48 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-24 18:48 ` Sourceware to Gerrit sync (Code Review)
2019-10-24 18:50 ` Christian Biesinger (Code Review) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024185046.E80E4204C9@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=simon.marchi@polymtl.ca \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox