Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>,
	       Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] xtensa: Avoid designated inits, for C++ compliance
Date: Fri, 26 Aug 2016 09:39:00 -0000	[thread overview]
Message-ID: <62e78020-2079-2c29-08c9-f930c43c37ea@redhat.com> (raw)
In-Reply-To: <20160826090148.GA27461@host1.jankratochvil.net>

On 08/26/2016 10:01 AM, Jan Kratochvil wrote:
> On Thu, 25 Aug 2016 13:56:25 +0200, Andreas Arnez wrote:
>> C++ does not officially support designators in initializer lists.
> 
> I could miss something about the transition to C++ (...)

You're missing that we haven't dropped support for building with
a C compiler yet...

We're still doing many 7.12 backports, so I was waiting for that
to stabilize before proposing to drop C support.

> The checked in change
> makes the source apparently more error prone to future changes.  Why not the
> attached?

Note that this header is meant to be replaced as part of an "overlay".
See:

 http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File
 https://www.sourceware.org/ml/gdb-patches/2015-04/msg00695.html

> I have noticed now the C++ conversion does not seem to be complete to me
> - struct gdbarch_tdep is defined differently for different translation units,
> this violates:
> 	https://en.wikipedia.org/wiki/One_Definition_Rule

Right, we're not LTO-ready yet.  Note -Wodr (w/ -flto) helps find these.

Thanks,
Pedro Alves


  parent reply	other threads:[~2016-08-26  9:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25 11:56 Andreas Arnez
2016-08-25 16:33 ` Pedro Alves
2016-08-25 17:17   ` Andreas Arnez
2016-08-26  9:42     ` Pedro Alves
2016-08-26 11:39       ` Andreas Arnez
2016-08-26  9:02 ` Jan Kratochvil
2016-08-26  9:07   ` Eli Zaretskii
2016-08-26  9:39   ` Pedro Alves [this message]
2016-08-26 10:10     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62e78020-2079-2c29-08c9-f930c43c37ea@redhat.com \
    --to=palves@redhat.com \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox