From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25541 invoked by alias); 26 Aug 2016 09:39:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25531 invoked by uid 89); 26 Aug 2016 09:39:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=www.sourceware.org, sk:www.sou, UD:www.sourceware.org, wwwsourcewareorg X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Aug 2016 09:39:30 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FEEC13D19; Fri, 26 Aug 2016 09:39:29 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7Q9dShK011048; Fri, 26 Aug 2016 05:39:28 -0400 Subject: Re: [PATCH] xtensa: Avoid designated inits, for C++ compliance To: Jan Kratochvil , Andreas Arnez References: <20160826090148.GA27461@host1.jankratochvil.net> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <62e78020-2079-2c29-08c9-f930c43c37ea@redhat.com> Date: Fri, 26 Aug 2016 09:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160826090148.GA27461@host1.jankratochvil.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-08/txt/msg00281.txt.bz2 On 08/26/2016 10:01 AM, Jan Kratochvil wrote: > On Thu, 25 Aug 2016 13:56:25 +0200, Andreas Arnez wrote: >> C++ does not officially support designators in initializer lists. > > I could miss something about the transition to C++ (...) You're missing that we haven't dropped support for building with a C compiler yet... We're still doing many 7.12 backports, so I was waiting for that to stabilize before proposing to drop C support. > The checked in change > makes the source apparently more error prone to future changes. Why not the > attached? Note that this header is meant to be replaced as part of an "overlay". See: http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File https://www.sourceware.org/ml/gdb-patches/2015-04/msg00695.html > I have noticed now the C++ conversion does not seem to be complete to me > - struct gdbarch_tdep is defined differently for different translation units, > this violates: > https://en.wikipedia.org/wiki/One_Definition_Rule Right, we're not LTO-ready yet. Note -Wodr (w/ -flto) helps find these. Thanks, Pedro Alves