Re: [PING][8.3 backport] Adjust i386 registers on SystemTap probes' arguments (PR breakpoints/24541)

[Tom de Vries <tdevries@suse.de>]

On 09-09-19 22:53, Joel Brobecker wrote:
>>>> OK to backport both commits to gdb-8.3-branch?
>>>
>>> Ping.
>>
>> I'm the maintainer of the SystemTap/generic probe interfaces, but I'm
>> not sure I can give you the green light for you in this case, because
>> it's about backporting to a branch.  In any case, just to make sure I'm
>> clear: this one LGTM.
> 
> Generally speaking, the rule is that a GM needs to approve the backport.
> But the nod from the associated maintainer is always a great help.
> So thanks a lot, Sergio!
> 
> I looked it over, and this seems safe to have. So the backport is
> approved.
> 

Thanks for the review.

> One thing that would have helped a bit is if the commits were attached
> to the request. It's clearly not a big issue at all, but if they had
> been attached, there would have been no mistake possible fo which
> commits we are talking about, and looking through them would have been
> faster.
> 

Ack, I'll try to remember this for next time.

Thanks,
- Tom

> For the record, I looked at:
>   677052f2a5 Make stap-probe.c:stap_parse_register_operand's "regname" an std::string
>   7d7571f0c1 Adjust i386 registers on SystemTap probes' arguments (PR breakpoints/24541)
>