Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Lancelot SIX <Lancelot.Six@amd.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Cc: aburgess@redhat.com
Subject: Re: [PATCH] gdbsupport/common-inferior.c: Fix mingw build
Date: Mon, 31 Mar 2025 14:06:36 +0100	[thread overview]
Message-ID: <62589d0e-9137-4d6a-9a0a-644f8f23773f@amd.com> (raw)
In-Reply-To: <1d68bef7-5917-438f-a6ee-58ce73b2fbfd@suse.de>


> Hi Lancelot,
> 
> thanks for fixing this.
> 
> I've reproduced the problem, and verified that the patch fixes it.
> 
> I've looked at the patch introducing the problem, and I agree with the fix.
> 
> Approved-By: Tom de Vries <tdevries@suse.de>
> 
> FWIW, there's a pre-existing style issue here, the strpbrk should be
> explicitly tested against nullptr, but I noticed the same issue in
> another file, so I propose that we leave this patch as is, and that I
> follow up with a patch taking care of that issue in both files.
> 
> Thanks,
> - Tom

Thanks,

I pushed that initial fix as 7b34a95034f.

Best,
Lancelot.

      reply	other threads:[~2025-03-31 13:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31 11:13 Lancelot SIX
2025-03-31 12:23 ` Tom de Vries
2025-03-31 13:06   ` Lancelot SIX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62589d0e-9137-4d6a-9a0a-644f8f23773f@amd.com \
    --to=lancelot.six@amd.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox