From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rLZLEJGT6mdHDSEAWB0awg (envelope-from ) for ; Mon, 31 Mar 2025 09:07:29 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Usg0+1LX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 28D161E0C3; Mon, 31 Mar 2025 09:07:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 074E51E05C for ; Mon, 31 Mar 2025 09:07:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 97342386548F for ; Mon, 31 Mar 2025 13:07:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 97342386548F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Usg0+1LX Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2060c.outbound.protection.outlook.com [IPv6:2a01:111:f403:2416::60c]) by sourceware.org (Postfix) with ESMTPS id 051D0385840C for ; Mon, 31 Mar 2025 13:06:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 051D0385840C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 051D0385840C Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:2416::60c ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1743426406; cv=pass; b=entn3jqKIBj+tBXFSPlRPNU9jopKbhsZVgvEKY+PR1glnbam1NdsNBLhfQRvCRHP4wO3vhPNSxpCzonY1SjehHq5B0UaXZYJv6Bk0DQMrTEDAdzgASUzyeUsokSQ5AGNrH3frlXUXKuAvtrH43Wz6NplkZFAawdu8eFA/ejOwz4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1743426406; c=relaxed/simple; bh=oxJorTLrxk2LvyRwX8Gr9OBySN5IrYtChdtRB7GdfCs=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=JgOzbN/edFaMbO55TJ/bqcYCdKqaz7JTQLzet32LgD9CgNHn8II29iSfQZ/0GOPeeHeXSdAY/CLNqL3Be2syljRsUHtlV7Nkr91Q0w/3swxFDlvSsL7+Hn0LhpsJvCTl41LcvuvJp9BOgr8Qid7jCdJI1EauqvVrULmO9e/w1cQ= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 051D0385840C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aVk4sZcGHFlgaUcEE+nV4w94x/E7okCcb+tH4kd/gfi/rQM49gWlleI3k0ewLObzO575B3GCrnGPIAUG8vGUz59NcLSOcVtUxBm2ljPpLgnNw8F5j2cHnpKeziOH5LFSnakOhOdpdvtwDNQ4zNdKR4off4Q8h1+TBaFIgNI0AcoHj27/sQNEkdPIhKryvt1ElP/6w775sHlfRCUwWg0PiAtvFr0o2HfASKg1EnYSFr63qMZ070o1OxcJZneNe1vvhm+0HHMtifVLnVKRv88quQlvgs3zG9hljBna+dYjskfDN8hWMcyN1/q7iCpmJ0W2lcG/wwRuM3OC+2OiH1e0kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vCxi7P0UV5abuMOCx3t1fTa/B8zohG9CVewW8kgP2MI=; b=ujXk3VHnrPqqrRR96HoOFr78iEAeAD0MwKgjUTosNiasS6H/Zq4FsWD9YH4Z/x2T484gEIbETfLIhRA5xjHiYdfqgHN6/EmwPOsaPQ5SLQvllZWK06faHKoiMwS29PT4YEPYeZt+Uscus7b3ypy0UPTrwYfU7HK2rgFm+qbkQttZEnwsHakEgIOojDSKYA26XxGWUP1l/nHP60NYNZGOmjDLq2VnRHmwgX9ZPPwRHGpqOwhVlETnqNv0NvFMiw9dDfxCsfIAAwq7k0g32sr3peU0oTkptHSh39/NbP1OZ8MzK4WkWksKstpUdPaSgKnDBU3MJ7WnKRCyaM7gyVHXZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vCxi7P0UV5abuMOCx3t1fTa/B8zohG9CVewW8kgP2MI=; b=Usg0+1LXXcfa6eibe5NktLisuZosHnuD4NGXX7AfhLgl9MKY3Js8amJ1iYg7thq/Ryp5oSOU4OTDDX8PtQsVPp/KK2m0wbN90oaESFAoSQlqLph0L9xZfTnR1gRvARBCjJEKmLQSqDtzOcqPBlXXNkX/5UNfTvnMx5HskT6IvvI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by DS0PR12MB8200.namprd12.prod.outlook.com (2603:10b6:8:f5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.44; Mon, 31 Mar 2025 13:06:41 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::8c67:8cec:7c4a:ccaa]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::8c67:8cec:7c4a:ccaa%4]) with mapi id 15.20.8534.048; Mon, 31 Mar 2025 13:06:40 +0000 Message-ID: <62589d0e-9137-4d6a-9a0a-644f8f23773f@amd.com> Date: Mon, 31 Mar 2025 14:06:36 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdbsupport/common-inferior.c: Fix mingw build To: Tom de Vries , gdb-patches@sourceware.org Cc: aburgess@redhat.com References: <20250331111358.200153-1-lancelot.six@amd.com> <1d68bef7-5917-438f-a6ee-58ce73b2fbfd@suse.de> Content-Language: en-US From: Lancelot SIX In-Reply-To: <1d68bef7-5917-438f-a6ee-58ce73b2fbfd@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0095.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::7) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|DS0PR12MB8200:EE_ X-MS-Office365-Filtering-Correlation-Id: a3601e1f-2215-4f3f-c3a1-08dd7054e09b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VTFOSzM2eVZlN1VGR0FmaUs3NHpYRVMzV2MwUmZ3Z0gvMVRYRFE0M0p4Y2lK?= =?utf-8?B?S2VYT0hJZUhRSkc2WllDeDZldTR0djNmMHhFU3JYL1ZjMGNQaUVHYzhaTit3?= =?utf-8?B?QVIrR3dmN01ub096U0pLRE9ZdzlnR1FQeWQyZ1U1TGpYcG43ZXVEeFQ4cUZX?= =?utf-8?B?bXZBNkRyclZFWi83bld2THROdmhrT1dqZUhrL2JxL1pNY2FzcHdKdVljRVNU?= =?utf-8?B?T0RtN1BtQnYxRFBETVBIaStaLzN5TFdQeXBqR3JsTVFQcXFYVGlqTUEvTEpj?= =?utf-8?B?eUVPSytleTZ2cjBzY3NmRVZFQ2F2elVGNnRQaG9XdGlqaEZnK2drNU5Temdl?= =?utf-8?B?VTNLUlhlMThwNytnc3Z0Umd6bGtZZ0VIVEhGcEJkdEVFRGRvRW5GWDczVk9w?= =?utf-8?B?dUIzZTlpZmpsODNzMVdydCtYYTY4RUFBSFJSN25uTTdobWhYdmhHTVhoU0lP?= =?utf-8?B?YnpLSXBUd0ljcStXK0FBcFhBQXlEejVtNFdJNE1HRDJMQWtsemdGV3BDbGRq?= =?utf-8?B?MnVUcC9zSC80Y3p5L3A0bkw2c3RLYW1wWFRDeVkzTlZZbXJaUHQ2Qms5MGl0?= =?utf-8?B?QmdIVGU3Zk5XOEF6amVIdzRHenRiOWtQK2pzU2RIWnRzUU5LMjZJRFZZVGUw?= =?utf-8?B?U20rZDR3QysyMVRUNUphVWl6SFVtWC8yWVc4RDhKbnVXWU9OVEVpb1dCRjBL?= =?utf-8?B?Rm52VEJQdWtOcHBzcjBRVG1GM2xpMWM5VldEZVVTSEFkc2ZMYmdYWTVvSnAr?= =?utf-8?B?cUNrZ1lmbjN3Vit4c05TMDY1K2dWbk9sNyt6R1YyNzFvd1dUbHpGWmY2RHVT?= =?utf-8?B?dU45cHJDemNCZU1vMmhubXJOZ3NRcnNiNnlLSkRqYU40eE0wb2plSmxRZURB?= =?utf-8?B?YlFic2pFK2RGYStlaXJDVzV1cGlIVkdxK0xDMW5lc1BOS2RJUlluKzdYNVdx?= =?utf-8?B?S1VnU0ZNWEdGeWhCN252eGl2L2RIQUh1S3Q4eUp2bzhxZkIxd1N4c0YxVUpM?= =?utf-8?B?SVJoMWlqWEsybTdBWUNUdVNsUFY5YlZHeFpGaDgwSDRIM3pON3RkTnA4OE0w?= =?utf-8?B?UUdSTU1QQVZ0Z2J6YTJtbjd5Mk04N05Xc3J3K2t6cFA0cFg4aWtwMHZ0cFNp?= =?utf-8?B?Rm5NZWg3SWRGem54MGhyOEx3VlNoanN1SWY5RmpqOXhiWjVLajAydXFkZXdy?= =?utf-8?B?b0xHdUlndi9raEpyays0K1NQa0dKWkN6SG9WUklmNnBHaVJ1OGJKKzlscTcw?= =?utf-8?B?eDNSOEZIVENQUTJ5ZDNVSlkvZVp2UFRtc1NORHpHSjhSdnNRaHZXS0FicmlU?= =?utf-8?B?VHJaQXpIMklFS3JXTCt4NzYxekFabjF6dGhXY3lURHgvdFQ0N3E4eG1qcDB4?= =?utf-8?B?OHdUSUNpalQ1YTg5all6ZkR6cTlwdlhRZ0hxVXlBZEd6eHNtUENlSFBTa2s3?= =?utf-8?B?SUdRc1I0aGM2WGZ3RVpuemdlK1UyRnBHQmQwcXRQV1d2RE5PTjhRQXptRVhC?= =?utf-8?B?SU1tT3NUWDFKcm55bStTMHFBSDdBbjZySGEyNkhHUytGakRhR3A2OWl0R1oy?= =?utf-8?B?aWplaUNCT05CYTk2bDMrQzNXcW1kRWl4WXVNeEdWNTdZQkVCcDI1czQ3Q2h0?= =?utf-8?B?b0k5TjBKN0lJWCtQZnNxem43M1R1cmhaNTE2VEpqNkk2U3R3N3dENm1HTUxs?= =?utf-8?B?dUNvMzlYSWswVENBV1VCVGlnMm45R0hTMStTVFp6L1N2TkM4ZUpsQjJKbm1G?= =?utf-8?B?YTBnNmo2eVVYOUd3WEFqc21wY2lRWmpJWFhTSE1abUE3cUxMNmN5cVR3d0Qr?= =?utf-8?B?Z3ZHb3lLd3VVUGRIR1hrVkIyaUhrR2kzc0ZnRmVUUTFjTWVTV0U1UFZHL3hx?= =?utf-8?Q?TsmYXHRzlPipH?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDN5UHh0c0xNaHNBdFpxSVJiemFad2l3ZkFPcWpER2VLbkl3d1ZmZXdqenJy?= =?utf-8?B?Rk5ua1JSOXZvOEpFVTJuNEFDZm0zMXNqcXFQTmp4bWZGK0hEb3RQVkFnOFlh?= =?utf-8?B?T0dLK2k3T21mMEUxZDRJSmJ1TjhDUzhLMTlxYWx1aGR6c3g0T2JVbW4wbzJK?= =?utf-8?B?b1NWbTNzWFR1OXlKcnFrbk1hT0M5S0t1S094ckxyUnJ5YkdnZUZ1dlZyMlZD?= =?utf-8?B?K2FXdjlneWh5bm1QTjk4OCsvSVpHY1VUVTZOZDdCOFUzQ280YkliSEVYRDRB?= =?utf-8?B?MG9vZUVoSC9pKzhzK1lpV0pqZEtEU0ZDWXJ5bmQzTnVIQitXOFFwbjhtVVJM?= =?utf-8?B?M3p5ZzAzaC92TlpRL05zRXBoalFaWjRYSEJPZjIyUWR1cWdtKzdUdHZEeUl1?= =?utf-8?B?THJBRVVjNHVqWE1zSHhSb1Q3aHg1b1c0dWlIUkpVUkhhMWN2TVpSZ0NrZG9l?= =?utf-8?B?K3E5NTBpQnl4UHJXdGZFUVVlaEo4UHk0eGtYRXVXalZwc2FidFIyc2pUOUlk?= =?utf-8?B?NkJIMlJpcDhublMzbXQ0bGVNSzlZNDhNSG9IK2tDVk9LSzh4eVBLc3FKbXJ2?= =?utf-8?B?cjFnVVVJbjJyWDMzNTlUTVB0eDNCSGtWSHF6S0pDK1o0TlRBRXVWRUJHS3R2?= =?utf-8?B?anNHVXUySmlmdmMySlEyeEFLL2xEeGhqVWRIYVNuTlpvSjNqR2dSLzdKUzVG?= =?utf-8?B?OC9Db0FTZVFjT3FkVjdkMVBLS3krdXdVcVBINDlTZGJtdkxzSUxVRWFXeFpr?= =?utf-8?B?aWlBZStGUFJ5SEpjMlpicUlFN2NPYzhkRUtmM3E5MkpvSjdpT2tZOXhNbi9D?= =?utf-8?B?WVk4QkszT0dEZi91eFRMd0RtdGRUcno5ak5lVGFIanlTa1R6NWd1V3ZCbUU2?= =?utf-8?B?RTV5eFBXbC9qUExncFh6ajUvM0NIMkI5U0EyNngyK1oxME1hUThrTGNpUlFO?= =?utf-8?B?ZHpsN1lud1BZOEQ0THcvdmhCRjYxRE11UHZKVmZGMUxvY1U4L3dkUUl0RTAz?= =?utf-8?B?eWk2R3ZWcnVCRUZEWFpxbjBsU2ZzM1ljWk9YMEtrRFJSSTQ1dlZkVFhHS0FO?= =?utf-8?B?Z2lpME5jT3dYalJ0c0RuL3BDa291L2ZiazgvTEJGZzhObStDTEFKbDQyaUZK?= =?utf-8?B?U3RqSWhEVlNzakxNSzZML1ZrZzN6eHNKUTZpeUVxbWNqRmxVOTd0NVZ2TmU1?= =?utf-8?B?Y1oxSHNNRlI4S2dwbUtrSVNJRG9Xc1NBSnFQYm4zMk80VVZVeHJqTE8xTXBR?= =?utf-8?B?bGdLYUxQdlJFYTJHWUhjeitVZjZHMEY1eFlOeTRIanZhck9vQnFJOEQvSE0y?= =?utf-8?B?VXRlbVZWNDQ5TGhvVEt6WXBzNWhYY0Z5UHp2Z09LMENKOHlmRzFlODlBU1Np?= =?utf-8?B?Z0VNV2JtMkNTUFE1RWFqMzl6aDlIMTZ0d1kvUWttUno0SUUrZ0tQd3diRHBS?= =?utf-8?B?ZFllSkZ1QU04cDM4c2FNSkZzYzN6ZEl1YXFNRmxWOVdHWnJDeG83RDl3Mnk1?= =?utf-8?B?TXp5dmtSY3JOM1c5TTdCL1VNNHU3cmY0N3lwbndaZzcvREpTV2hSbTBGY3BR?= =?utf-8?B?RzRScGtrVytiL1lwOHZIRzgra205eTdWaUJXMFBwYWtMWVB5UlkzYTE3aFZy?= =?utf-8?B?b3Z0R2FxOHY2cmE1SUZlSTk4dzBWcEc3OCt5dlYxN0hBeGVHbHRNSkpwSGRK?= =?utf-8?B?bTd5V3g2MkRHNjhRZGx1UG5FOFVsdG1QODBUV0hBWGJxajZZb1loSzZvK2tn?= =?utf-8?B?alNKR0RBNjFlWXVyWnpMMVEzSDRvYUh3bkRrWnI1bU1EODRxWG0vL0VQUXFX?= =?utf-8?B?M1VjVnllMGsrQUR6NDBEb3pzY3V2bE9iN2szblJqYVZmN3YxRlN5c0VRcDJD?= =?utf-8?B?RXl2YTdnN05IckdxREhSUlZTbGF1azdPNnVaaEZrM2ZNQVZ6YVpPMWRCamp4?= =?utf-8?B?amxDVW5ZM0hPUFkyM3NvODFsaXFpTk5qRllVcis1TlBsdUNPbi9GaGdJb1B5?= =?utf-8?B?L3NtZno0ZTNkaW1LMDlHQXNQYm8rRnhmNzZRQUd4dVgxak8xUU9IVU5MYm5L?= =?utf-8?B?S3hpeGFtQ0NWTzY3dlMzRE9zcGxxZWtlbDJxMi9abFBpVWlFRzV4Y0RiSDJB?= =?utf-8?Q?vn31FBHA9gdhDj9rPEtbV5Dx/?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3601e1f-2215-4f3f-c3a1-08dd7054e09b X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2025 13:06:40.7688 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9N+OYGt46JXJgA5dCO7mMRfwdlUVvL1+l6FeUz9fPdrw51u87qurXH7WrkO1OS9jGIFkpvdHg9myCrgBTcB6Ww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8200 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > Hi Lancelot, > > thanks for fixing this. > > I've reproduced the problem, and verified that the patch fixes it. > > I've looked at the patch introducing the problem, and I agree with the fix. > > Approved-By: Tom de Vries > > FWIW, there's a pre-existing style issue here, the strpbrk should be > explicitly tested against nullptr, but I noticed the same issue in > another file, so I propose that we leave this patch as is, and that I > follow up with a patch taking care of that issue in both files. > > Thanks, > - Tom Thanks, I pushed that initial fix as 7b34a95034f. Best, Lancelot.