From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove field_info::nfields member
Date: Thu, 27 Feb 2020 21:28:00 -0000 [thread overview]
Message-ID: <6171c9c7-9006-b3dd-84fb-764ae1b7fb17@simark.ca> (raw)
In-Reply-To: <20200227211124.5097-1-tromey@adacore.com>
On 2020-02-27 4:11 p.m., Tom Tromey wrote:
> @@ -15336,7 +15337,7 @@ process_structure_scope (struct die_info *die, struct dwarf2_cu *cu)
> }
>
> /* Attach fields and member functions to the type. */
> - if (fi.nfields)
> + if (fi.nfields ())
Let's change this to
if (fi.nfields () != 0)
or
if (fi.nfields () > 0)
Otherwise, LGTM.
Simon
prev parent reply other threads:[~2020-02-27 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 21:11 Tom Tromey
2020-02-27 21:28 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6171c9c7-9006-b3dd-84fb-764ae1b7fb17@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox