From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1690 invoked by alias); 27 Feb 2020 21:28:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1671 invoked by uid 89); 27 Feb 2020 21:28:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Feb 2020 21:28:38 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E5ADC1E512; Thu, 27 Feb 2020 16:28:36 -0500 (EST) Subject: Re: [PATCH] Remove field_info::nfields member To: Tom Tromey , gdb-patches@sourceware.org References: <20200227211124.5097-1-tromey@adacore.com> From: Simon Marchi Message-ID: <6171c9c7-9006-b3dd-84fb-764ae1b7fb17@simark.ca> Date: Thu, 27 Feb 2020 21:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200227211124.5097-1-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg01029.txt.bz2 On 2020-02-27 4:11 p.m., Tom Tromey wrote: > @@ -15336,7 +15337,7 @@ process_structure_scope (struct die_info *die, struct dwarf2_cu *cu) > } > > /* Attach fields and member functions to the type. */ > - if (fi.nfields) > + if (fi.nfields ()) Let's change this to if (fi.nfields () != 0) or if (fi.nfields () > 0) Otherwise, LGTM. Simon