Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: jtc@redbacknetworks.com (J.T. Conklin)
To: gdb-patches@cygnus.com
Subject: Patch to support NACK packet from stub
Date: Thu, 01 Apr 1999 00:00:00 -0000	[thread overview]
Message-ID: <5mu2vqw2co.fsf@jtc.redbacknetworks.com> (raw)

I discovered that the putpkt() routine does not handle NACK ('-')
packets from remote stub, instead the NACK is junked and putpkt()
waits until the subsequent read times out.  This is a big penalty
(the default value of remote_timeout is 20 seconds) that can be 
easily avoided.

However, I had the '-' case fall through to SERIAL_TIMEOUT so the
number of attempts a packet is sent is the same as timeouts.  If we
wanted to add a remote_debug for the SERIAL_TIMEOUT case, that code
needs to duplicated.

	--jtc

1999-03-12  J.T. Conklin  <jtc@redbacknetworks.com>

	* remote.c (putpkt): Handle NACK ('-') packet from stub.

Index: remote.c
===================================================================
RCS file: /usr/rback/release/tools-src/gdb/gdb/remote.c,v
retrieving revision 1.5
diff -c -r1.5 remote.c
*** remote.c	1999/02/15 21:33:55	1.5
--- remote.c	1999/03/13 02:20:20
***************
*** 2537,2542 ****
--- 2537,2543 ----
  	      switch (ch)
  		{
  		case '+':
+ 		case '-':
  		case SERIAL_TIMEOUT:
  		case '$':
  		  if (started_error_output)
***************
*** 2553,2558 ****
--- 2554,2563 ----
  	      if (remote_debug)
  		printf_unfiltered ("Ack\n");
  	      return 1;
+ 	    case '-':
+ 	      if (remote_debug)
+ 		printf_unfiltered ("Nack\n");
+ 	      /* FALLTHROUGH */
  	    case SERIAL_TIMEOUT:
  	      tcount ++;
  	      if (tcount > 3)




-- 
J.T. Conklin
RedBack Networks


WARNING: multiple messages have this Message-ID
From: jtc@redbacknetworks.com (J.T. Conklin)
To: gdb-patches@cygnus.com
Subject: Patch to support NACK packet from stub
Date: Fri, 12 Mar 1999 18:28:00 -0000	[thread overview]
Message-ID: <5mu2vqw2co.fsf@jtc.redbacknetworks.com> (raw)
Message-ID: <19990312182800.nTNJNVBzqiaxwMYtjEjWW3NNY-zXmLHaKA1rgr8IkRQ@z> (raw)

I discovered that the putpkt() routine does not handle NACK ('-')
packets from remote stub, instead the NACK is junked and putpkt()
waits until the subsequent read times out.  This is a big penalty
(the default value of remote_timeout is 20 seconds) that can be 
easily avoided.

However, I had the '-' case fall through to SERIAL_TIMEOUT so the
number of attempts a packet is sent is the same as timeouts.  If we
wanted to add a remote_debug for the SERIAL_TIMEOUT case, that code
needs to duplicated.

	--jtc

1999-03-12  J.T. Conklin  <jtc@redbacknetworks.com>

	* remote.c (putpkt): Handle NACK ('-') packet from stub.

Index: remote.c
===================================================================
RCS file: /usr/rback/release/tools-src/gdb/gdb/remote.c,v
retrieving revision 1.5
diff -c -r1.5 remote.c
*** remote.c	1999/02/15 21:33:55	1.5
--- remote.c	1999/03/13 02:20:20
***************
*** 2537,2542 ****
--- 2537,2543 ----
  	      switch (ch)
  		{
  		case '+':
+ 		case '-':
  		case SERIAL_TIMEOUT:
  		case '$':
  		  if (started_error_output)
***************
*** 2553,2558 ****
--- 2554,2563 ----
  	      if (remote_debug)
  		printf_unfiltered ("Ack\n");
  	      return 1;
+ 	    case '-':
+ 	      if (remote_debug)
+ 		printf_unfiltered ("Nack\n");
+ 	      /* FALLTHROUGH */
  	    case SERIAL_TIMEOUT:
  	      tcount ++;
  	      if (tcount > 3)




-- 
J.T. Conklin
RedBack Networks


             reply	other threads:[~1999-04-01  0:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-04-01  0:00 J.T. Conklin [this message]
1999-03-12 18:28 ` J.T. Conklin
     [not found] <5mu2vqw2co.fsf.cygnus.patches.gdb@jtc.redbacknetworks.com>
1999-04-01  0:00 ` Andrew Cagney
1999-03-17 14:05   ` Andrew Cagney
1999-03-17 16:54   ` J.T. Conklin
1999-04-01  0:00     ` J.T. Conklin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5mu2vqw2co.fsf@jtc.redbacknetworks.com \
    --to=jtc@redbacknetworks.com \
    --cc=gdb-patches@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox