Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: jtc@redback.com (J.T. Conklin)
To: "John R. Moore" <jmoore@cygnus.com>
Cc: Kevin Buettner <kevinb@cygnus.com>, <gdb-patches@sources.redhat.com>
Subject: Re: xfree() -- set ptr to nil (fwd)
Date: Mon, 12 Feb 2001 15:54:00 -0000	[thread overview]
Message-ID: <5mofw71mqo.fsf@jtc.redback.com> (raw)
In-Reply-To: <Pine.GSO.4.31.0102121527310.16672-100000@cse.cygnus.com>

>>>>> "John" == John R Moore <jmoore@cygnus.com> writes:
John> Yes, I've usually seen this as a macro
John>
John> #define XFREE(ptr) do \
John> { \
John>  if (ptr) \
John>   { \
John>     free (ptr); \
John>     ptr = NULL; \
John>   } \
John> } while (0)
John>
John> Ok, then, do we want to replace xfree() with something like XFREE() ?

I'd say no, unless it has been established that we have a problem
where pointers are freed multiple times AND it's been determined that
its too difficult to fix the code to avoid the bug.

        --jtc

-- 
J.T. Conklin
RedBack Networks


  parent reply	other threads:[~2001-02-12 15:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-12 15:07 John R. Moore
2001-02-12 15:21 ` Kevin Buettner
2001-02-12 15:33   ` John R. Moore
2001-02-12 15:46     ` Daniel Berlin
2001-02-12 15:52       ` John R. Moore
2001-02-12 15:54     ` J.T. Conklin [this message]
2001-02-12 15:25 ` J.T. Conklin
2001-02-12 16:01 Michael Elizabeth Chastain
2001-02-13 14:12 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5mofw71mqo.fsf@jtc.redback.com \
    --to=jtc@redback.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jmoore@cygnus.com \
    --cc=kevinb@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox