From: Michael Elizabeth Chastain <chastain@cygnus.com>
To: jmoore@cygnus.com, kevinb@cygnus.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: xfree() -- set ptr to nil (fwd)
Date: Mon, 12 Feb 2001 16:01:00 -0000 [thread overview]
Message-ID: <200102130001.QAA23491@bosch.cygnus.com> (raw)
John Moore writes:
> Ok, then, do we want to replace xfree() with something like XFREE() ?
This gets into a philosophical discussion. Here is my philosophy.
Others may differ.
Basically, I am interested in work that leads to patches that get applied
and have concrete, observable gains. If someone can identify specific
bugs that we've had in gdb as a result of xfree problems, then I would
be interested in safety work such as s/xfree/XFREE/g, arranging to run
gdb regularly under Purify, and projects like that.
But I haven't seen problems like that so s/xfree/XFREE/g does not appeal
to me.
This is just a guideline. I really liked Kevin Buettner's PARAMS removal
patches, for example. In that case, the code afterwards was uneqivocally
simpler than the code before.
My two cents. And I'm not a maintainer, just a write-after-approval guy.
Michael Elizabeth Chastain
<chastain@redhat.com>
"love without fear"
next reply other threads:[~2001-02-12 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-12 16:01 Michael Elizabeth Chastain [this message]
2001-02-13 14:12 ` Andrew Cagney
-- strict thread matches above, loose matches on Subject: below --
2001-02-12 15:07 John R. Moore
2001-02-12 15:21 ` Kevin Buettner
2001-02-12 15:33 ` John R. Moore
2001-02-12 15:46 ` Daniel Berlin
2001-02-12 15:52 ` John R. Moore
2001-02-12 15:54 ` J.T. Conklin
2001-02-12 15:25 ` J.T. Conklin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200102130001.QAA23491@bosch.cygnus.com \
--to=chastain@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jmoore@cygnus.com \
--cc=kevinb@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox