From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove init_cli_cmds
Date: Thu, 11 Jul 2019 15:58:00 -0000 [thread overview]
Message-ID: <5ebba330-5766-80bb-a398-f540c19044ad@redhat.com> (raw)
In-Reply-To: <20190711153134.5887-1-tromey@adacore.com>
On 7/11/19 4:31 PM, Tom Tromey wrote:
> I noticed that init_cli_cmds only installs a command, and so doesn't
> need to be handled specially. This patch merges it into
> _initialize_cli_cmds.
>
> The help text is constructed dynamically, which is sometimes an
> indication that special treatment is needed; but in this case it is
> just to insert the value of "gdbinit", which is created at
> compile-time and not modified; so this doesn't affect the result.
I wonder why we have a gdbinit variable at all, instead of using
the GDBINIT macro directly.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-07-11 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 15:31 Tom Tromey
2019-07-11 15:58 ` Pedro Alves [this message]
2019-07-11 16:21 ` Tom Tromey
2019-07-11 16:26 ` Tom Tromey
2019-07-11 16:30 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ebba330-5766-80bb-a398-f540c19044ad@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox