From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87049 invoked by alias); 11 Jul 2019 15:58:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87039 invoked by uid 89); 11 Jul 2019 15:58:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:607 X-HELO: mail-wm1-f66.google.com Received: from mail-wm1-f66.google.com (HELO mail-wm1-f66.google.com) (209.85.128.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jul 2019 15:58:22 +0000 Received: by mail-wm1-f66.google.com with SMTP id g67so2099694wme.1 for ; Thu, 11 Jul 2019 08:58:22 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id u9sm5705823wrr.30.2019.07.11.08.58.20 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jul 2019 08:58:20 -0700 (PDT) Subject: Re: [PATCH] Remove init_cli_cmds To: Tom Tromey , gdb-patches@sourceware.org References: <20190711153134.5887-1-tromey@adacore.com> From: Pedro Alves Message-ID: <5ebba330-5766-80bb-a398-f540c19044ad@redhat.com> Date: Thu, 11 Jul 2019 15:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190711153134.5887-1-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00320.txt.bz2 On 7/11/19 4:31 PM, Tom Tromey wrote: > I noticed that init_cli_cmds only installs a command, and so doesn't > need to be handled specially. This patch merges it into > _initialize_cli_cmds. > > The help text is constructed dynamically, which is sometimes an > indication that special treatment is needed; but in this case it is > just to insert the value of "gdbinit", which is created at > compile-time and not modified; so this doesn't affect the result. I wonder why we have a gdbinit variable at all, instead of using the GDBINIT macro directly. Thanks, Pedro Alves