From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>,
Bernd Edlinger <bernd.edlinger@hotmail.de>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCHv2] Fix setting breakpoints or stepping on line 65535
Date: Sun, 29 Dec 2019 20:41:00 -0000 [thread overview]
Message-ID: <5ea099d0-6fc4-c4b1-06b1-a0403f92eb7a@simark.ca> (raw)
In-Reply-To: <20191229203253.GP3865@embecosm.com>
On 2019-12-29 3:32 p.m., Andrew Burgess wrote:
> I place more value on having tests and changes in the same commit - I
> find it more useful the other way around, when I find some code I
> don't understand and I figure out which commit it came from, having
> the tests in the same commit means it is easy to know "this test"
> should check "this code".
>
> If the test and changes are separate I have to do more work. Boo!
>
> For this reason, if you've not already pushed this patch, could you
> collapse the test and change into a single commit please before
> pushing.
FWIW, that's my preference too.
Simon
next prev parent reply other threads:[~2019-12-29 20:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 11:54 [PATCH] " Bernd Edlinger
2019-12-01 20:46 ` [PING] " Bernd Edlinger
2019-12-01 22:08 ` Andrew Burgess
2019-12-02 18:04 ` [PATCHv2] " Bernd Edlinger
2019-12-14 13:57 ` [PING] " Bernd Edlinger
2019-12-28 8:46 ` [PING**2] " Bernd Edlinger
2019-12-29 19:46 ` Simon Marchi
2019-12-29 20:32 ` Andrew Burgess
2019-12-29 20:41 ` Simon Marchi [this message]
2019-12-29 21:24 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ea099d0-6fc4-c4b1-06b1-a0403f92eb7a@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=bernd.edlinger@hotmail.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox