From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122766 invoked by alias); 29 Dec 2019 20:41:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122755 invoked by uid 89); 29 Dec 2019 20:41:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 spammy=UD:m X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 29 Dec 2019 20:41:19 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 99D811E092; Sun, 29 Dec 2019 15:41:17 -0500 (EST) Subject: Re: [PATCHv2] Fix setting breakpoints or stepping on line 65535 To: Andrew Burgess , Bernd Edlinger Cc: "gdb-patches@sourceware.org" References: <20191201220818.GI3410@embecosm.com> <20191229203253.GP3865@embecosm.com> From: Simon Marchi Message-ID: <5ea099d0-6fc4-c4b1-06b1-a0403f92eb7a@simark.ca> Date: Sun, 29 Dec 2019 20:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20191229203253.GP3865@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg01064.txt.bz2 On 2019-12-29 3:32 p.m., Andrew Burgess wrote: > I place more value on having tests and changes in the same commit - I > find it more useful the other way around, when I find some code I > don't understand and I figure out which commit it came from, having > the tests in the same commit means it is easy to know "this test" > should check "this code". > > If the test and changes are separate I have to do more work. Boo! > > For this reason, if you've not already pushed this patch, could you > collapse the test and change into a single commit please before > pushing. FWIW, that's my preference too. Simon