Re: [RFC 0/3] [pre-commit] Add shfmt

[Tom de Vries <tdevries@suse.de>]

On 9/2/26 3:17 PM, Tom de Vries wrote:
> This series contains three patches.
> 
> The first adds an shfmt pre-commit hook.
> 
> The second enables it and uses it to format all shell scripts.
> 
> The third adds shfmt --simplify.
> 
> This is an RFC, given the large amount of changes that reformatting brings.
> 
> It would be nice to find a formatter closer to the current style.
> 

I'm also working on an alternative using emacs, similar to this ( 
https://sourceware.org/pipermail/gdb-patches/2026-September/230047.html 
), which will probably result in less changes.

Of course that wouldn't provide this nice reformatting:
...
$ cat test.sh
if true
then
     echo foo;
fi
$ shfmt test.sh
if true; then
	echo foo
fi
$
...

Thanks,
- Tom

> Tom de Vries (3):
>    [pre-commit] Add shfmt
>    [pre-commit] Enable shfmt
>    [gdb/contrib] Use shfmt --simplify in shfmt.sh
> 
>   .pre-commit-config.yaml                     |  10 ++
>   gdb/contrib/cc-with-tweaks.sh               |  80 +++++----
>   gdb/contrib/check-file-mode.sh              |  16 +-
>   gdb/contrib/check-gnu-style-pre-commit.sh   |   5 +-
>   gdb/contrib/gdb-add-index.sh                | 104 ++++++------
>   gdb/contrib/pre-commit.py                   |   6 +-
>   gdb/contrib/shellcheck.sh                   |   6 +-
>   gdb/contrib/shfmt.sh                        |  84 +++++++++
>   gdb/contrib/words.sh                        |  20 +--
>   gdb/doc/makeinfo-wrapper.sh                 |  14 +-
>   gdb/gcore-1.in                              | 141 +++++++--------
>   gdb/gdb_buildall.sh                         | 123 ++++++--------
>   gdb/gdb_mbuild.sh                           | 179 +++++++++-----------
>   gdb/gstack-1.in                             |  25 +--
>   gdb/make-init-c                             |   2 +-
>   gdb/po/gdbtext                              |  23 +--
>   gdb/syscalls/update-freebsd.sh              |  12 +-
>   gdb/syscalls/update-linux-defaults.sh       |  29 ++--
>   gdb/syscalls/update-linux-from-src.sh       |  25 ++-
>   gdb/syscalls/update-linux.sh                |  26 +--
>   gdb/syscalls/update-netbsd.sh               |  12 +-
>   gdb/testsuite/lib/dg-add-core-file-count.sh |   6 +-
>   gdb/testsuite/lib/notty-wrap                |   2 +-
>   gdb/testsuite/make-check-all.sh             |  22 +--
>   24 files changed, 524 insertions(+), 448 deletions(-)
>   create mode 100755 gdb/contrib/shfmt.sh
> 
> 
> base-commit: 192afd3ce7c2324cdbee2d4646df6cf1e9b6fd09