From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AtdkEwPEuGpemwsAWB0awg (envelope-from ) for ; Sun, 27 Sep 2026 03:21:39 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pcaBhFYY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=iuRpKZBr; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=jrneZHMn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=eCHO8L+P; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 077581E033; Sun, 27 Sep 2026 03:21:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AE5CE1E033 for ; Sun, 27 Sep 2026 03:21:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 406214BA9020 for ; Sun, 27 Sep 2026 07:21:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 406214BA9020 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pcaBhFYY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=iuRpKZBr; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=jrneZHMn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=eCHO8L+P Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 77F0F4BA79BB for ; Sun, 27 Sep 2026 07:21:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 77F0F4BA79BB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 77F0F4BA79BB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790493670; cv=none; b=XxHg9v92PWNHVv8Zx8F+51scPsp70CFB7hfFqzzgaoa61qhfmeKqK0o4eBRLipNapVkQ5Ig8AnDyXOVUQuTgGRp9WogCHzG2SVD4tW59taz0wNgPlV0MPaET64SYCIlqp+I+trKpziQ0YmgiiqkVjmdOiQKX7/pHQiX2ma+pu8o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790493670; c=relaxed/simple; bh=dVjQ28yrYy5ku3ipYWAj7aoRBhox9PthT7fpHibpqnc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=ZDinVEtFZhsh4E+/AE9hlVajnveKtaqmTFV4N5zua1ib6jq+tedFcspFdpGWvco/oML4tylqtjxUnw+KZaV6mArWzKJMJpFoBq233Gn/n7Bkd2B1/GQeP8YO9xAR3e+mp0kh6jWHJYu/cH4XZZiVBmANwxh1JJRBVmhIClbxRPs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pcaBhFYY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=iuRpKZBr; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=jrneZHMn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=eCHO8L+P DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 77F0F4BA79BB Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0C08C1F787 for ; Sun, 27 Sep 2026 07:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790493665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eGdaM8SSSjBqex90mjASZhMXIEbCDtwjCY35X9r4X5o=; b=pcaBhFYYRI9FuaqSqDbK5yGoIkmoG97F6D2uAlf/FbzH1qrweyfJg+uKvXgCRE0KXY/gsX BGbn6JfzSjDFLVa0NrtDlUVe4S1KFjFXbO3veqncX15QKSvE5Wr5Qzv00bqe3g1vBYYJVb 8aPb8ijc7qWACZYka8GNP896OOIc/tc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790493665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eGdaM8SSSjBqex90mjASZhMXIEbCDtwjCY35X9r4X5o=; b=iuRpKZBrLBYH3LRs7qUQW9QHGzQFQjd8P3Tb8z9dD8Lh4ErJHq69GcPEMcc1192FIGnOvh 59Ku1DUdXJC0e3Aw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790493661; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eGdaM8SSSjBqex90mjASZhMXIEbCDtwjCY35X9r4X5o=; b=jrneZHMnHou8tVaiBeoArmQQ5DTosyylJOrArBd5YoZxxW6aBx150v9tAMHYJ8Nfo4PAC7 6Z+BxFKgfsUsE6TaNOeV2G8sF/BUrbfvkWgCm2NrIPrfXswR5TIN42j95UozRwxAiiCM4L A0kJ3jWnPTj9s29AYkGo3i4E/S/NMx0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790493661; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eGdaM8SSSjBqex90mjASZhMXIEbCDtwjCY35X9r4X5o=; b=eCHO8L+PlugdGzOf9cHhwo/pCxj03C7sYRwSdTErGmC+MCCGF2QiUxL/m2d2uneD1Dn+AJ OaQpXz7s1Lzy6bAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AEA4613274 for ; Sun, 27 Sep 2026 07:21:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OSadGdzDuGogCgAAD6G6ig (envelope-from ) for ; Sun, 27 Sep 2026 07:21:00 +0000 Message-ID: <5d9b88c2-0d79-4590-9dca-0b30bff900c4@suse.de> Date: Sun, 27 Sep 2026 09:21:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 0/3] [pre-commit] Add shfmt From: Tom de Vries To: gdb-patches@sourceware.org References: <20260902131739.2125928-1-tdevries@suse.de> Content-Language: en-US In-Reply-To: <20260902131739.2125928-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.995]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/2/26 3:17 PM, Tom de Vries wrote: > This series contains three patches. > > The first adds an shfmt pre-commit hook. > > The second enables it and uses it to format all shell scripts. > > The third adds shfmt --simplify. > > This is an RFC, given the large amount of changes that reformatting brings. > > It would be nice to find a formatter closer to the current style. > I'm also working on an alternative using emacs, similar to this ( https://sourceware.org/pipermail/gdb-patches/2026-September/230047.html ), which will probably result in less changes. Of course that wouldn't provide this nice reformatting: ... $ cat test.sh if true then echo foo; fi $ shfmt test.sh if true; then echo foo fi $ ... Thanks, - Tom > Tom de Vries (3): > [pre-commit] Add shfmt > [pre-commit] Enable shfmt > [gdb/contrib] Use shfmt --simplify in shfmt.sh > > .pre-commit-config.yaml | 10 ++ > gdb/contrib/cc-with-tweaks.sh | 80 +++++---- > gdb/contrib/check-file-mode.sh | 16 +- > gdb/contrib/check-gnu-style-pre-commit.sh | 5 +- > gdb/contrib/gdb-add-index.sh | 104 ++++++------ > gdb/contrib/pre-commit.py | 6 +- > gdb/contrib/shellcheck.sh | 6 +- > gdb/contrib/shfmt.sh | 84 +++++++++ > gdb/contrib/words.sh | 20 +-- > gdb/doc/makeinfo-wrapper.sh | 14 +- > gdb/gcore-1.in | 141 +++++++-------- > gdb/gdb_buildall.sh | 123 ++++++-------- > gdb/gdb_mbuild.sh | 179 +++++++++----------- > gdb/gstack-1.in | 25 +-- > gdb/make-init-c | 2 +- > gdb/po/gdbtext | 23 +-- > gdb/syscalls/update-freebsd.sh | 12 +- > gdb/syscalls/update-linux-defaults.sh | 29 ++-- > gdb/syscalls/update-linux-from-src.sh | 25 ++- > gdb/syscalls/update-linux.sh | 26 +-- > gdb/syscalls/update-netbsd.sh | 12 +- > gdb/testsuite/lib/dg-add-core-file-count.sh | 6 +- > gdb/testsuite/lib/notty-wrap | 2 +- > gdb/testsuite/make-check-all.sh | 22 +-- > 24 files changed, 524 insertions(+), 448 deletions(-) > create mode 100755 gdb/contrib/shfmt.sh > > > base-commit: 192afd3ce7c2324cdbee2d4646df6cf1e9b6fd09