From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Always fetch Ada "main" name from the executable
Date: Fri, 31 Jul 2026 11:48:34 +0100 [thread overview]
Message-ID: <5cbe3b5e-9f68-43c8-8b5f-01eeaea2c2a8@palves.net> (raw)
In-Reply-To: <20260730170336.2547536-1-tromey@adacore.com>
FWIW, I was intrigued by the subject, so I took a look, and ...
On 2026-07-30 18:03, Tom Tromey wrote:
> The gdb.ada/file-then-restart.exp test was failing with gnat-llvm. I
> tracked this down to the "main" name not being stored in a readonly
> section, meaning that the code in ada_main_name using trust_readonly
> did not work.
>
> However, it seems to me that gdb should always prefer the data from
> the executable in this particular case. So, rather than relying on
> trust_readonly, this patch changes gdb to do this directly.
... this LGTM.
Approved-By: Pedro Alves <pedro@palves.net>
next prev parent reply other threads:[~2026-07-31 10:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 17:03 Tom Tromey
2026-07-31 10:48 ` Pedro Alves [this message]
2026-08-05 17:07 ` Andrew Burgess
2026-08-07 13:55 ` Tom Tromey
2026-08-07 15:03 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cbe3b5e-9f68-43c8-8b5f-01eeaea2c2a8@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox