From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZlHGCat9bGoyJjcAWB0awg (envelope-from ) for ; Fri, 31 Jul 2026 06:49:15 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=cCdZ96uF; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F1DB11E099; Fri, 31 Jul 2026 06:49:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E36171E099 for ; Fri, 31 Jul 2026 06:49:13 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A08004B1A29C for ; Fri, 31 Jul 2026 10:49:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A08004B1A29C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=cCdZ96uF Received: from heron.birch.relay.mailchannels.net (heron.birch.relay.mailchannels.net [23.83.209.82]) by sourceware.org (Postfix) with ESMTPS id CDC7A4BCA2E3 for ; Fri, 31 Jul 2026 10:48:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDC7A4BCA2E3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=palves.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CDC7A4BCA2E3 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=23.83.209.82 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785494922; cv=none; b=KxSiUZ4k/FOHyrT357Ldg5JR+nndX0wwKuOhHkGAXfL+q0UfFdudjcwRC4Nxvs9d+7Az0UuioZAt+kbQDMIArAUAXZxVP8solrUtayEPscZPy3pgg17cJFOrAWZ2W6FkJC85SVIGT8/B8CLQoQQJoNPZgGrtBbGXoXHfx/bEcjQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785494922; c=relaxed/simple; bh=bxdnkYeiezTNBwWQXcg6D1pndajyZKyyqKzBWjlRyW8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=HEiAO6A0vqcMQCh00/L2opBh8I8l/nPa64cnwuuMdftDa2bOuvldWoWvmS+bgO3jOqL9TBazPRN6xO+VsA9xpVwRHHNHy+CzYyWf+ikjdsvoJWPZTWaQT9TNLI1tpicxXulbCqH0bHsonTVmOO51JDEFHnJH8hzFwcqP9kCtk7k= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=cCdZ96uF DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDC7A4BCA2E3 X-Sender-Id: dreamhost|x-authsender|pedro@palves.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 895E54E3598; Fri, 31 Jul 2026 10:48:40 +0000 (UTC) Received: from pdx1-sub0-mail-a203.dreamhost.com (trex-green-1.trex.outbound.svc.cluster.local [100.108.68.76]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3B6974E3403; Fri, 31 Jul 2026 10:48:36 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|pedro@palves.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|pedro@palves.net X-MailChannels-Auth-Id: dreamhost X-Shrill-Wiry: 6fade6664d3a11fe_1785494920406_1752705455 X-MC-Loop-Signature: 1785494920406:2252535179 X-MC-Ingress-Time: 1785494920406 Received: from pdx1-sub0-mail-a203.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.108.68.76 (trex/8.0.2); Fri, 31 Jul 2026 10:48:40 +0000 Received: from [192.168.0.201] (bl20-181-64.dsl.telepac.pt [2.81.181.64]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pedro@palves.net) by pdx1-sub0-mail-a203.dreamhost.com (Postfix) with ESMTPSA id 4hBN8g3rGPz1H; Fri, 31 Jul 2026 03:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=palves.net; s=dreamhost; t=1785494916; bh=Gp0vuqmh0ZP9hC6dLs76uC+jyDd2L/ImRLSBUYAw5o4=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=cCdZ96uFTnFgs3lTGrsUKzNyGTMtqxz+5qEPmX1YM8YAKuDluK/oMvo9RP4J40bmp 3OBB33M5ij4oz9Ual/Fuex9G1A69VL30yLiFJ2lOa2YHm4njB1CXkKgZL9Avj8h+HX RkQN6SkD3LFIjNiJTz7oB9tDYre5spW0Bq6bMutp849+Zh3+sypjyPYSdaAI61n2/r 7tuD6MBAKtwUwfsJtBdokbeh3m/0afvwiJiM6CPdNAr3P6wnVyU9x650kI+c96meeB S5NTIJ1S4Y/CH3H12WrLcJN86cjcfq2+vf5s0SATvvjzp61FreOwZ5+hbfA4KgOAYo /xUmYXHhjehAg== Message-ID: <5cbe3b5e-9f68-43c8-8b5f-01eeaea2c2a8@palves.net> Date: Fri, 31 Jul 2026 11:48:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Always fetch Ada "main" name from the executable To: Tom Tromey , gdb-patches@sourceware.org References: <20260730170336.2547536-1-tromey@adacore.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <20260730170336.2547536-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org FWIW, I was intrigued by the subject, so I took a look, and ... On 2026-07-30 18:03, Tom Tromey wrote: > The gdb.ada/file-then-restart.exp test was failing with gnat-llvm. I > tracked this down to the "main" name not being stored in a readonly > section, meaning that the code in ada_main_name using trust_readonly > did not work. > > However, it seems to me that gdb should always prefer the data from > the executable in this particular case. So, rather than relying on > trust_readonly, this patch changes gdb to do this directly. ... this LGTM. Approved-By: Pedro Alves