From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Class-ify ptid_t
Date: Thu, 06 Apr 2017 11:12:00 -0000 [thread overview]
Message-ID: <5c5e486c-54b1-31d7-887c-c3e92e667e6d@redhat.com> (raw)
In-Reply-To: <f4e8944d-220f-c749-c28d-a79663a76693@redhat.com>
On 04/06/2017 11:49 AM, Pedro Alves wrote:
> Yes, I think we should put that in the unit test with a comment
Or leave it in ptid.c, doesn't have to be in a separate file.
Putting it in the .c file instead of the .h has the advantage
that it doesn't expose type_traits.h to all of gdb, that's all.
(Though I'm not sure whether be able to avoid it as we grow more
C++ utilities.)
> so that if someone tries to add something that would make it
> non-pod, gdb won't even compile. If/when we get to the point where
> we can/want to make it non-pod, we can remove the assertion then.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-04-06 11:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 18:32 [PATCH 1/2] ptid_{lwp,tid}_p: Remove unnecessary checks Simon Marchi
2017-04-04 18:33 ` [PATCH 2/2] Class-ify ptid_t Simon Marchi
2017-04-05 15:47 ` Pedro Alves
2017-04-05 19:44 ` Simon Marchi
2017-04-05 21:31 ` Pedro Alves
2017-04-06 2:15 ` Simon Marchi
2017-04-06 10:49 ` Pedro Alves
2017-04-06 11:12 ` Pedro Alves [this message]
2017-04-06 14:32 ` Simon Marchi
2017-04-06 14:38 ` Pedro Alves
2017-04-06 3:09 ` Simon Marchi
2017-04-06 11:06 ` Pedro Alves
2017-04-05 15:15 ` [PATCH 1/2] ptid_{lwp,tid}_p: Remove unnecessary checks Pedro Alves
2017-04-05 19:21 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c5e486c-54b1-31d7-887c-c3e92e667e6d@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox