From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91464 invoked by alias); 6 Apr 2017 11:12:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90738 invoked by uid 89); 6 Apr 2017 11:12:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Apr 2017 11:12:20 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CB6873DD47; Thu, 6 Apr 2017 11:12:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CB6873DD47 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CB6873DD47 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id E935D9967A; Thu, 6 Apr 2017 11:12:19 +0000 (UTC) Subject: Re: [PATCH 2/2] Class-ify ptid_t To: Simon Marchi References: <20170404183235.10589-1-simon.marchi@ericsson.com> <20170404183235.10589-2-simon.marchi@ericsson.com> <580e9a8a-d59b-095c-cf56-ee2f50fe46df@redhat.com> <84b33a5c655af3f344494c9e9ee473d6@polymtl.ca> <03bc3933d454f9fa01567a0e1000e201@polymtl.ca> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <5c5e486c-54b1-31d7-887c-c3e92e667e6d@redhat.com> Date: Thu, 06 Apr 2017 11:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00140.txt.bz2 On 04/06/2017 11:49 AM, Pedro Alves wrote: > Yes, I think we should put that in the unit test with a comment Or leave it in ptid.c, doesn't have to be in a separate file. Putting it in the .c file instead of the .h has the advantage that it doesn't expose type_traits.h to all of gdb, that's all. (Though I'm not sure whether be able to avoid it as we grow more C++ utilities.) > so that if someone tries to add something that would make it > non-pod, gdb won't even compile. If/when we get to the point where > we can/want to make it non-pod, we can remove the assertion then. Thanks, Pedro Alves