From: Tristan Gingold <gingold@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] aix: add support for dwarf2.
Date: Tue, 24 May 2011 07:20:00 -0000 [thread overview]
Message-ID: <5EE240AB-A6C1-4925-92D2-E0C0BCFCC43B@adacore.com> (raw)
In-Reply-To: <m3r57p2z8c.fsf@fleche.redhat.com>
On May 23, 2011, at 5:49 PM, Tom Tromey wrote:
>>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:
>
> Tristan> static void
> Tristan> aix_process_linenos (void)
> Tristan> {
> Tristan> + if (this_symtab_psymtab == NULL)
> Tristan> + return;
>
> I don't understand this change.
This is just a guard.
process_linenos (called by aix_process_linenos) will dereference this_symtab_psymtab, which is set by read_xcoff_symtab.
However, if the psymtab is built by dwarf2, the variable will never be initialized.
Do you think the issue is somewhere else ?
>
> The rest looks ok to me.
Thank you for reviewing.
Tristan.
next prev parent reply other threads:[~2011-05-24 7:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 10:29 [RFA] Add dwarf2 support to xcoff (aix) Tristan Gingold
2011-05-23 10:29 ` [PATCH 1/4] Really make dwarf2_get_section_info public Tristan Gingold
2011-05-23 15:15 ` Tom Tromey
2011-05-24 12:41 ` Tristan Gingold
2011-05-23 10:29 ` [PATCH 4/4] bfd.c: hancle aixcoff in bfd_get_sign_extend_vma Tristan Gingold
2011-05-23 10:29 ` [PATCH 2/4] dwarf2read.c: handle alternate dwarf2 debug sections name Tristan Gingold
2011-05-23 15:22 ` Tom Tromey
2011-05-23 15:32 ` Tristan Gingold
2011-05-23 15:40 ` Tom Tromey
2011-05-26 7:48 ` Tristan Gingold
2011-05-23 10:35 ` [PATCH 3/4] aix: add support for dwarf2 Tristan Gingold
2011-05-23 15:35 ` Tom Tromey
2011-05-23 15:42 ` Tom Tromey
2011-05-23 15:47 ` Tristan Gingold
2011-05-23 15:50 ` Tom Tromey
2011-05-24 7:20 ` Tristan Gingold [this message]
2011-05-24 13:37 ` Tom Tromey
2011-05-24 13:44 ` Tristan Gingold
2011-05-24 14:56 ` Tom Tromey
2011-05-24 15:11 ` Tristan Gingold
2011-06-01 15:37 ` Tristan Gingold
2011-06-02 19:11 ` Tom Tromey
2011-06-07 12:32 ` Tristan Gingold
2011-05-23 16:00 ` [RFA] Add dwarf2 support to xcoff (aix) Yao Qi
2011-05-24 7:06 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5EE240AB-A6C1-4925-92D2-E0C0BCFCC43B@adacore.com \
--to=gingold@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox