From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-81239-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7076 invoked by alias); 24 May 2011 07:20:27 -0000
Received: (qmail 7054 invoked by uid 22791); 24 May 2011 07:20:26 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 May 2011 07:20:10 +0000
Received: from localhost (localhost [127.0.0.1])	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 0766BCB0364;	Tue, 24 May 2011 09:20:09 +0200 (CEST)
Received: from mel.act-europe.fr ([127.0.0.1])	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id lLKdigNeWRmi; Tue, 24 May 2011 09:20:04 +0200 (CEST)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67])	(using TLSv1 with cipher AES128-SHA (128/128 bits))	(No client certificate requested)	by mel.act-europe.fr (Postfix) with ESMTP id C6409CB0369;	Tue, 24 May 2011 09:20:01 +0200 (CEST)
Subject: Re: [PATCH 3/4] aix: add support for dwarf2.
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <m3r57p2z8c.fsf@fleche.redhat.com>
Date: Tue, 24 May 2011 07:20:00 -0000
Cc: gdb-patches@sourceware.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <5EE240AB-A6C1-4925-92D2-E0C0BCFCC43B@adacore.com>
References: <1306146544-3925-1-git-send-email-gingold@adacore.com> <1306146544-3925-4-git-send-email-gingold@adacore.com> <m3r57p2z8c.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-05/txt/msg00550.txt.bz2


On May 23, 2011, at 5:49 PM, Tom Tromey wrote:

>>>>>> "Tristan" =3D=3D Tristan Gingold <gingold@adacore.com> writes:
>=20
> Tristan>  static void
> Tristan>  aix_process_linenos (void)
> Tristan>  {
> Tristan> +  if (this_symtab_psymtab =3D=3D NULL)
> Tristan> +    return;
>=20
> I don't understand this change.

This is just a guard.
process_linenos (called by aix_process_linenos) will dereference this_symta=
b_psymtab, which is set by read_xcoff_symtab.
However, if the psymtab is built by dwarf2, the variable will never be init=
ialized.

Do you think the issue is somewhere else ?

>=20
> The rest looks ok to me.

Thank you for reviewing.

Tristan.