Re: Proposal to revert the gnulib update patch (was: Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24)

Re: Proposal to revert the gnulib update patch (was: Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24)

[Kyrill Tkachov]

Hi all,

Sorry for the improperly threaded reply, I'm not subscribed to gdb-patches.
I'd like to support reverting the patch mentioned here:
https://sourceware.org/ml/gdb-patches/2018-09/msg00039.html

As this is breaking our nightly toolchain builds as well.

Thanks,
Kyrill

Oh dear. I regret to inform you that commit 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24 might be unfortunate

[gdb-buildbot]

My lords, ladies, gentlemen, members of the public.

It is a matter of great regret and sadness to inform you that commit:

	Update gnulib to current upstream master
	7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

might have made GDB unwell.  Since I am just your Butler BuildBot,
I kindly ask that a human superior officer double-check this.

Please note that if you are reading this message on gdb-patches, there might
be other builders broken.

You can find more details about the unfortunate breakage in the next messages.

Cheers,

Your GDB BuildBot.

Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

[gdb-buildbot]

Unfortunately it seems that there is a breakage on GDB.

Commit title: 'Update gnulib to current upstream master'
Revision: 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

You can find more details below:

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

Buildslave:
	rhel-7_1-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/RHEL-s390x-m64/builds/8193>

Commit(s) tested:
	7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

Author(s) (in the same order as the commits):
	Sergio Durigan Junior <sergiodj@redhat.com>

Subject:
	Update gnulib to current upstream master

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/RHEL-s390x-m64/7a/7a6dbc2fdb2323c35e981f93236f323e9d7c0b24/>

*** Failed to compiled GDB.  ***
============================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

make[6]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
  GEN      alloca.h
  GEN      dirent.h
  GEN      glob.h
  GEN      fcntl.h
  GEN      inttypes.h
  GEN      limits.h
  GEN      math.h
  GEN      signal.h
  GEN      stdint.h
  GEN      stdio.h
  GEN      stdlib.h
  GEN      string.h
  GEN      sys/stat.h
  GEN      sys/time.h
  GEN      time.h
  GEN      sys/types.h
  GEN      unistd.h
  GEN      wchar.h
  GEN      wctype.h
make  all-recursive
make[7]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
make[8]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
  CC       cloexec.o
  CC       dirname-lgpl.o
  CC       basename-lgpl.o
  CC       stripslash.o
  CC       exitfail.o
  CC       fd-hook.o
  CC       fd-safer-flag.o
  CC       dup-safer-flag.o
  CC       filenamecat-lgpl.o
  CC       getprogname.o
  CC       hard-locale.o
  CC       malloca.o
  CC       localcharset.o
  CC       math.o
  CC       openat-die.o
  CC       save-cwd.o
  CC       stat-time.o
  CC       strnlen1.o
  CC       tempname.o
  CC       unistd.o
  CC       dup-safer.o
  CC       fd-safer.o
  CC       pipe-safer.o
  CC       wctype-h.o
  CC       chdir-long.o
  CC       fcntl.o
  CC       glob.o
  CC       glob_pattern_p.o
  CC       globfree.o
  CC       localtime-buffer.o
  CC       mbrtowc.o
  CC       openat-proc.o
  CC       malloc/scratch_buffer_grow.o
In file included from ../../../../binutils-gdb/gdb/gnulib/import/scratch_buffer.h:9:0,
                 from ../../../../binutils-gdb/gdb/gnulib/import/glob.c:87:
../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:3: error: unknown type name max_align_t
   max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
   ^
../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:39: error: max_align_t undeclared here (not in a function)
   max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
                                       ^
../../../../binutils-gdb/gdb/gnulib/import/glob.c: In function glob_in_dir:
../../../../binutils-gdb/gdb/gnulib/import/glob.c:1413:15: error: for loop initial declarations are only allowed in C99 mode
               for (size_t i = 0; i < cur; ++i)
               ^
../../../../binutils-gdb/gdb/gnulib/import/glob.c:1413:15: note: use option -std=c99 or -std=gnu99 to compile your code
../../../../binutils-gdb/gdb/gnulib/import/glob.c:1438:15: error: for loop initial declarations are only allowed in C99 mode
               for (size_t i = 0; i < cur; ++i)
               ^
make[8]: *** [glob.o] Error 1
make[8]: *** Waiting for unfinished jobs....
In file included from ../../../../binutils-gdb/gdb/gnulib/import/scratch_buffer.h:9:0,
                 from ../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer_grow.c:23:
../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:3: error: unknown type name max_align_t
   max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
   ^
../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:39: error: max_align_t undeclared here (not in a function)
   max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
                                       ^
make[8]: *** [malloc/scratch_buffer_grow.o] Error 1
make[8]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
make[7]: *** [all-recursive] Error 1
make[6]: make[7]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
*** [all] Error 2
make[6]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
make[5]: *** [subdir_do] Error 1
make[5]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib'
make[4]: *** [all] Error 2
make[4]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib'
make[3]: *** [subdir_do] Error 1
make[3]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb'
make[2]: *** [all-lib] Error 2
make[2]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb'
make[1]: *** [all-gdb] Error 2
make[1]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build'
make: *** [all] Error 2
============================

Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

[Sergio Durigan Junior]

On Wednesday, August 29 2018, gdb-buildbot wrote:

> Unfortunately it seems that there is a breakage on GDB.
>
> Commit title: 'Update gnulib to current upstream master'
> Revision: 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

I'm investigating this.

> You can find more details below:
>
> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
> Buildslave:
> 	rhel-7_1-s390x-1
>
> Full Build URL:
> 	<http://gdb-build.sergiodj.net/builders/RHEL-s390x-m64/builds/8193>
>
> Commit(s) tested:
> 	7a6dbc2fdb2323c35e981f93236f323e9d7c0b24
>
> Author(s) (in the same order as the commits):
> 	Sergio Durigan Junior <sergiodj@redhat.com>
>
> Subject:
> 	Update gnulib to current upstream master
>
> Testsuite log (gdb.sum and gdb.log) URL(s):
> 	<http://gdb-build.sergiodj.net/results/RHEL-s390x-m64/7a/7a6dbc2fdb2323c35e981f93236f323e9d7c0b24/>
>
> *** Failed to compiled GDB.  ***
> ============================
>
> +++ The full log is too big to be posted here.
> +++ These are the last 100 lines of it.
>
> make[6]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
>   GEN      alloca.h
>   GEN      dirent.h
>   GEN      glob.h
>   GEN      fcntl.h
>   GEN      inttypes.h
>   GEN      limits.h
>   GEN      math.h
>   GEN      signal.h
>   GEN      stdint.h
>   GEN      stdio.h
>   GEN      stdlib.h
>   GEN      string.h
>   GEN      sys/stat.h
>   GEN      sys/time.h
>   GEN      time.h
>   GEN      sys/types.h
>   GEN      unistd.h
>   GEN      wchar.h
>   GEN      wctype.h
> make  all-recursive
> make[7]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
> make[8]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
>   CC       cloexec.o
>   CC       dirname-lgpl.o
>   CC       basename-lgpl.o
>   CC       stripslash.o
>   CC       exitfail.o
>   CC       fd-hook.o
>   CC       fd-safer-flag.o
>   CC       dup-safer-flag.o
>   CC       filenamecat-lgpl.o
>   CC       getprogname.o
>   CC       hard-locale.o
>   CC       malloca.o
>   CC       localcharset.o
>   CC       math.o
>   CC       openat-die.o
>   CC       save-cwd.o
>   CC       stat-time.o
>   CC       strnlen1.o
>   CC       tempname.o
>   CC       unistd.o
>   CC       dup-safer.o
>   CC       fd-safer.o
>   CC       pipe-safer.o
>   CC       wctype-h.o
>   CC       chdir-long.o
>   CC       fcntl.o
>   CC       glob.o
>   CC       glob_pattern_p.o
>   CC       globfree.o
>   CC       localtime-buffer.o
>   CC       mbrtowc.o
>   CC       openat-proc.o
>   CC       malloc/scratch_buffer_grow.o
> In file included from ../../../../binutils-gdb/gdb/gnulib/import/scratch_buffer.h:9:0,
>                  from ../../../../binutils-gdb/gdb/gnulib/import/glob.c:87:
> ../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:3: error: unknown type name max_align_t
>    max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
>    ^
> ../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:39: error: max_align_t undeclared here (not in a function)
>    max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
>                                        ^
> ../../../../binutils-gdb/gdb/gnulib/import/glob.c: In function glob_in_dir:
> ../../../../binutils-gdb/gdb/gnulib/import/glob.c:1413:15: error: for loop initial declarations are only allowed in C99 mode
>                for (size_t i = 0; i < cur; ++i)
>                ^
> ../../../../binutils-gdb/gdb/gnulib/import/glob.c:1413:15: note: use option -std=c99 or -std=gnu99 to compile your code
> ../../../../binutils-gdb/gdb/gnulib/import/glob.c:1438:15: error: for loop initial declarations are only allowed in C99 mode
>                for (size_t i = 0; i < cur; ++i)
>                ^
> make[8]: *** [glob.o] Error 1
> make[8]: *** Waiting for unfinished jobs....
> In file included from ../../../../binutils-gdb/gdb/gnulib/import/scratch_buffer.h:9:0,
>                  from ../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer_grow.c:23:
> ../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:3: error: unknown type name max_align_t
>    max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
>    ^
> ../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:39: error: max_align_t undeclared here (not in a function)
>    max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
>                                        ^
> make[8]: *** [malloc/scratch_buffer_grow.o] Error 1
> make[8]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
> make[7]: *** [all-recursive] Error 1
> make[6]: make[7]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
> *** [all] Error 2
> make[6]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
> make[5]: *** [subdir_do] Error 1
> make[5]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib'
> make[4]: *** [all] Error 2
> make[4]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib'
> make[3]: *** [subdir_do] Error 1
> make[3]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb'
> make[2]: *** [all-lib] Error 2
> make[2]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb'
> make[1]: *** [all-gdb] Error 2
> make[1]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build'
> make: *** [all] Error 2
> ============================

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

[Sergio Durigan Junior]

On Wednesday, August 29 2018, I wrote:

> On Wednesday, August 29 2018, gdb-buildbot wrote:
>
>> Unfortunately it seems that there is a breakage on GDB.
>>
>> Commit title: 'Update gnulib to current upstream master'
>> Revision: 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24
>
> I'm investigating this.

Hello, David,

After my last commit, which updated GDB's local copy of gnulib, I'm
seeing a breakage on the RHEL 7.1 s390x builder (see the rest of the
quoted message).  Unfortunately I don't have easy access to a similar
machine, so I would like to know if:

1) You could help me with investigating this a bit more, or

2) You could grant me temporary access to the machine so I can
investigate the problem.

I would like to know a few things:

a) Why is GCC apparently not using the C99 mode when compiling gnulib.
This is causing the "‘for’ loop initial declarations are only allowed in
C99 mode" error.

b) Is there a "stddef.h" file in the build dir?  Does it declare
"max_align_t"?  This is causing the "unknown type name ‘max_align_t’"
error.

Thanks in advance,

>> You can find more details below:
>>
>> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>
>> Buildslave:
>> 	rhel-7_1-s390x-1
>>
>> Full Build URL:
>> 	<http://gdb-build.sergiodj.net/builders/RHEL-s390x-m64/builds/8193>
>>
>> Commit(s) tested:
>> 	7a6dbc2fdb2323c35e981f93236f323e9d7c0b24
>>
>> Author(s) (in the same order as the commits):
>> 	Sergio Durigan Junior <sergiodj@redhat.com>
>>
>> Subject:
>> 	Update gnulib to current upstream master
>>
>> Testsuite log (gdb.sum and gdb.log) URL(s):
>> 	<http://gdb-build.sergiodj.net/results/RHEL-s390x-m64/7a/7a6dbc2fdb2323c35e981f93236f323e9d7c0b24/>
>>
>> *** Failed to compiled GDB.  ***
>> ============================
>>
>> +++ The full log is too big to be posted here.
>> +++ These are the last 100 lines of it.
>>
>> make[6]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
>>   GEN      alloca.h
>>   GEN      dirent.h
>>   GEN      glob.h
>>   GEN      fcntl.h
>>   GEN      inttypes.h
>>   GEN      limits.h
>>   GEN      math.h
>>   GEN      signal.h
>>   GEN      stdint.h
>>   GEN      stdio.h
>>   GEN      stdlib.h
>>   GEN      string.h
>>   GEN      sys/stat.h
>>   GEN      sys/time.h
>>   GEN      time.h
>>   GEN      sys/types.h
>>   GEN      unistd.h
>>   GEN      wchar.h
>>   GEN      wctype.h
>> make  all-recursive
>> make[7]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
>> make[8]: Entering directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
>>   CC       cloexec.o
>>   CC       dirname-lgpl.o
>>   CC       basename-lgpl.o
>>   CC       stripslash.o
>>   CC       exitfail.o
>>   CC       fd-hook.o
>>   CC       fd-safer-flag.o
>>   CC       dup-safer-flag.o
>>   CC       filenamecat-lgpl.o
>>   CC       getprogname.o
>>   CC       hard-locale.o
>>   CC       malloca.o
>>   CC       localcharset.o
>>   CC       math.o
>>   CC       openat-die.o
>>   CC       save-cwd.o
>>   CC       stat-time.o
>>   CC       strnlen1.o
>>   CC       tempname.o
>>   CC       unistd.o
>>   CC       dup-safer.o
>>   CC       fd-safer.o
>>   CC       pipe-safer.o
>>   CC       wctype-h.o
>>   CC       chdir-long.o
>>   CC       fcntl.o
>>   CC       glob.o
>>   CC       glob_pattern_p.o
>>   CC       globfree.o
>>   CC       localtime-buffer.o
>>   CC       mbrtowc.o
>>   CC       openat-proc.o
>>   CC       malloc/scratch_buffer_grow.o
>> In file included from ../../../../binutils-gdb/gdb/gnulib/import/scratch_buffer.h:9:0,
>>                  from ../../../../binutils-gdb/gdb/gnulib/import/glob.c:87:
>> ../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:3: error: unknown type name max_align_t
>>    max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
>>    ^
>> ../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:39: error: max_align_t undeclared here (not in a function)
>>    max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
>>                                        ^
>> ../../../../binutils-gdb/gdb/gnulib/import/glob.c: In function glob_in_dir:
>> ../../../../binutils-gdb/gdb/gnulib/import/glob.c:1413:15: error: for loop initial declarations are only allowed in C99 mode
>>                for (size_t i = 0; i < cur; ++i)
>>                ^
>> ../../../../binutils-gdb/gdb/gnulib/import/glob.c:1413:15: note: use option -std=c99 or -std=gnu99 to compile your code
>> ../../../../binutils-gdb/gdb/gnulib/import/glob.c:1438:15: error: for loop initial declarations are only allowed in C99 mode
>>                for (size_t i = 0; i < cur; ++i)
>>                ^
>> make[8]: *** [glob.o] Error 1
>> make[8]: *** Waiting for unfinished jobs....
>> In file included from ../../../../binutils-gdb/gdb/gnulib/import/scratch_buffer.h:9:0,
>>                  from ../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer_grow.c:23:
>> ../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:3: error: unknown type name max_align_t
>>    max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
>>    ^
>> ../../../../binutils-gdb/gdb/gnulib/import/malloc/scratch_buffer.h:69:39: error: max_align_t undeclared here (not in a function)
>>    max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];
>>                                        ^
>> make[8]: *** [malloc/scratch_buffer_grow.o] Error 1
>> make[8]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
>> make[7]: *** [all-recursive] Error 1
>> make[6]: make[7]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
>> *** [all] Error 2
>> make[6]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib/import'
>> make[5]: *** [subdir_do] Error 1
>> make[5]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib'
>> make[4]: *** [all] Error 2
>> make[4]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb/build-gnulib'
>> make[3]: *** [subdir_do] Error 1
>> make[3]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb'
>> make[2]: *** [all-lib] Error 2
>> make[2]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb'
>> make[1]: *** [all-gdb] Error 2
>> make[1]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build'
>> make: *** [all] Error 2
>> ============================
>
> -- 
> Sergio
> GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
> Please send encrypted e-mail if possible
> http://sergiodj.net/

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

[Tom Tromey]

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> After my last commit, which updated GDB's local copy of gnulib, I'm
Sergio> seeing a breakage on the RHEL 7.1 s390x builder (see the rest of the
Sergio> quoted message).  Unfortunately I don't have easy access to a similar
Sergio> machine, so I would like to know if:

Something fishy is going on that builder.  I did a try run of my ubsan
series and got many errors like this:

(gdb) break check_vx
/usr/include/c++/4.8.2/debug/vector:
Error: attempt to subscript container with out-of-bounds index gdb: /home/dje/src/gcc-6-branch/libstdc++-v3/src/c++11/debug.cc:942: void {anonymous}::print_string({anonymous}::PrintContext&, const char*, const _Parameter*, std::size_t): Assertion `param_index < num_parameters' failed.

However I think this should only happen if libstdc++ debug mode is
enabled.  (Is this correct?  Maybe this is the error.)

I did do some try runs in the past of libstdc++ debug mode.  So, I am
wondering if there could somehow be stale .o files around.  I don't see
how really -- I'd expect configure to make config.h, and for that to
force a full rebuild.  But it still looks suspicious.

Tom

Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

[Sergio Durigan Junior]

On Wednesday, August 29 2018, Tom Tromey wrote:

>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> After my last commit, which updated GDB's local copy of gnulib, I'm
> Sergio> seeing a breakage on the RHEL 7.1 s390x builder (see the rest of the
> Sergio> quoted message).  Unfortunately I don't have easy access to a similar
> Sergio> machine, so I would like to know if:
>
> Something fishy is going on that builder.  I did a try run of my ubsan
> series and got many errors like this:
>
> (gdb) break check_vx
> /usr/include/c++/4.8.2/debug/vector:
> Error: attempt to subscript container with out-of-bounds index gdb:
> /home/dje/src/gcc-6-branch/libstdc++-v3/src/c++11/debug.cc:942: void
> {anonymous}::print_string({anonymous}::PrintContext&, const char*,
> const _Parameter*, std::size_t): Assertion `param_index <
> num_parameters' failed.
>
> However I think this should only happen if libstdc++ debug mode is
> enabled.  (Is this correct?  Maybe this is the error.)

Thanks, Tom.  This may have something to do with the errors, I think.

> I did do some try runs in the past of libstdc++ debug mode.  So, I am
> wondering if there could somehow be stale .o files around.  I don't see
> how really -- I'd expect configure to make config.h, and for that to
> force a full rebuild.  But it still looks suspicious.

Yeah, the BuildBot does a full rebuild for every commit.  It deletes the
previous build directory before starting the next build.

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

[Tom Tromey]

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> Yeah, the BuildBot does a full rebuild for every commit.  It deletes the
Sergio> previous build directory before starting the next build.

Ok, that makes great sense.

I wonder why I see those errors then.

Tom

Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

[Sergio Durigan Junior]

On Wednesday, August 29 2018, Tom Tromey wrote:

>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> Yeah, the BuildBot does a full rebuild for every commit.  It deletes the
> Sergio> previous build directory before starting the next build.
>
> Ok, that makes great sense.
>
> I wonder why I see those errors then.

I found the cause and explained it here:

  https://lists.gnu.org/archive/html/bug-gnulib/2018-08/msg00157.html

Since this is an problem with the relationship between our build system
and gnulib's, I'll include gdb-patches in my next reply to this thread,
so that we're all involved in the discussion.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

[Tom Tromey]

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Tom> I wonder why I see those errors then.

Sergio> I found the cause and explained it here:

Sergio>   https://lists.gnu.org/archive/html/bug-gnulib/2018-08/msg00157.html

I think mine are different because they seem to come from libstd++ debug
mode.  Jonathan Wakely gave me some suggestions on how to track this
down, but I haven't done it yet.

Tom

Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24

[Jonah Graham]

> b) Is there a "stddef.h" file in the build dir?  Does it declare
> "max_align_t"?  This is causing the "unknown type name ‘max_align_t’"
> error.

Our daily build (for Eclipse CDT testing) of GDB's master has started
failing because of this issue too:
https://ci.eclipse.org/cdt/job/debug-tests-master-gdb-master/1666/console

The issue seems to be assuming max_align_t is available, but it is not
available unless compiling with c11 mode (or similar). As we are using
4.8.5 the default is still gnu90.

From our build:

00:03:54.417 gcc -DHAVE_CONFIG_H -I. -I../../../../gdb/gnulib/import
-I..     -g -O2 -MT malloc/scratch_buffer_grow.o -MD -MP -MF
$depbase.Tpo -c -o malloc/scratch_buffer_grow.o
../../../../gdb/gnulib/import/malloc/scratch_buffer_grow.c &&\
00:03:54.417 mv -f $depbase.Tpo $depbase.Po
00:03:54.440 In file included from
../../../../gdb/gnulib/import/scratch_buffer.h:9:0,
00:03:54.440                  from
../../../../gdb/gnulib/import/malloc/scratch_buffer_grow.c:23:
00:03:54.440 ../../../../gdb/gnulib/import/malloc/scratch_buffer.h:69:3:
error: unknown type name ‘max_align_t’
00:03:54.440    max_align_t __space[(1023 + sizeof (max_align_t)) /
sizeof (max_align_t)];
00:03:54.440    ^
00:03:54.440 ../../../../gdb/gnulib/import/malloc/scratch_buffer.h:69:39:
error: ‘max_align_t’ undeclared here (not in a function)
00:03:54.440    max_align_t __space[(1023 + sizeof (max_align_t)) /
sizeof (max_align_t)];
00:03:54.440                                        ^
00:03:54.441 Makefile:1836: recipe for target
'malloc/scratch_buffer_grow.o' failed
00:03:54.441 make[8]: *** [malloc/scratch_buffer_grow.o] Error 1
00:03:54.441 make[8]: Leaving directory
'/jobs/genie.cdt/debug-tests-master-gdb-master/workspace/bin-utils/build/gdb/build-gnulib/import'

Proposal to revert the gnulib update patch (was: Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24)

[Sergio Durigan Junior]

On Monday, September 03 2018, Jonah Graham wrote:

>> b) Is there a "stddef.h" file in the build dir?  Does it declare
>> "max_align_t"?  This is causing the "unknown type name ‘max_align_t’"
>> error.
>
> Our daily build (for Eclipse CDT testing) of GDB's master has started
> failing because of this issue too:
> https://ci.eclipse.org/cdt/job/debug-tests-master-gdb-master/1666/console

Thanks, Jonah.

I'm thinking about reverting the gnulib update patch.  I'm on PTO this
week (in theory :-/), and not sure if I'll be able to address these
issues in a timely manner.  Aside from this c11 issue, there's also the
mingw compilation failure.

Since the main reason for updating gnulib was to fix PR gdb/23558, as a
workaround, I propose that we backport just the upstream gnulib patch
that fixes the problem:

a96d2e67052c879b1bcc5bc461722beac75fc372

I'd like to hear your opinions.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: Proposal to revert the gnulib update patch (was: Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24)

[Jonah Graham]

On Tue, 4 Sep 2018 at 01:46, Sergio Durigan Junior <sergiodj@redhat.com> wrote:
> I'd like to hear your opinions.

In the short term it would make my life easier. However at some point
c11 should be allowed for GDB source. If gdb maintainers want to make
that change now CDT will figure out how to manage.

I have put in a request to Eclipse Infrastructure to get a newer GCC
on our build machines already:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=538538