From: Simon Marchi <simon.marchi@polymtl.ca>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Stafford Horne <shorne@gmail.com>,
GDB patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] xtensa: Properly strdup string when building reggroup
Date: Mon, 12 Jun 2017 08:38:00 -0000 [thread overview]
Message-ID: <590b6ff49c8bc167ca2e179ec14818b0@polymtl.ca> (raw)
In-Reply-To: <86poe9aa4y.fsf@gmail.com>
On 2017-06-12 10:22, Yao Qi wrote:
> This exposes another bug, IMO, here,
>
> for (i = 0; i < XTENSA_MAX_COPROCESSOR; i++)
> {
> cpname[2] = '0' + i;
> xtensa_cp[i] = reggroup_new (cpname, USER_REGGROUP);
> }
>
> and XTENSA_MAX_COPROCESSOR is 0x10, so we can see "cp:", "cp;", which
> looks odd.
Heh, looks like the patch here
https://sourceware.org/ml/gdb-patches/2011-03/msg00571.html
did not take that into account :)
next prev parent reply other threads:[~2017-06-12 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 13:34 Stafford Horne
2017-06-12 8:22 ` Yao Qi
2017-06-12 8:38 ` Simon Marchi [this message]
2017-06-13 10:06 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=590b6ff49c8bc167ca2e179ec14818b0@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox