From: Stafford Horne <shorne@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Yao Qi <qiyaoltc@gmail.com>, GDB patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] xtensa: Properly strdup string when building reggroup
Date: Tue, 13 Jun 2017 10:06:00 -0000 [thread overview]
Message-ID: <20170613100624.GE6190@lianli.shorne-pla.net> (raw)
In-Reply-To: <590b6ff49c8bc167ca2e179ec14818b0@polymtl.ca>
On Mon, Jun 12, 2017 at 10:38:09AM +0200, Simon Marchi wrote:
> On 2017-06-12 10:22, Yao Qi wrote:
> > This exposes another bug, IMO, here,
> >
> > for (i = 0; i < XTENSA_MAX_COPROCESSOR; i++)
> > {
> > cpname[2] = '0' + i;
> > xtensa_cp[i] = reggroup_new (cpname, USER_REGGROUP);
> > }
> >
> > and XTENSA_MAX_COPROCESSOR is 0x10, so we can see "cp:", "cp;", which
> > looks odd.
>
> Heh, looks like the patch here
>
> https://sourceware.org/ml/gdb-patches/2011-03/msg00571.html
>
> did not take that into account :)
Right, I might was well resend the patch with an sprintf().
-Stafford
prev parent reply other threads:[~2017-06-13 10:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 13:34 Stafford Horne
2017-06-12 8:22 ` Yao Qi
2017-06-12 8:38 ` Simon Marchi
2017-06-13 10:06 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613100624.GE6190@lianli.shorne-pla.net \
--to=shorne@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox