From: Simon Marchi <simon.marchi@polymtl.ca>
To: Ruslan Kabatsayev <b7.10110111@gmail.com>
Cc: Pedro Alves <palves@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Remove some variables in favor of using gdb::optional
Date: Sat, 24 Aug 2019 23:56:00 -0000 [thread overview]
Message-ID: <58b2c8d82f3f42588bc1b75f74e1f453@polymtl.ca> (raw)
In-Reply-To: <CAHEcG97oD2XBGN=XpX5heLDx+quFiJHyXwoaS0vmbePsoPbaEA@mail.gmail.com>
On 2019-08-24 07:22, Ruslan Kabatsayev wrote:
> Since GDB uses C++11, and we don't really rely on conversion to int
> here, why not use enum class? This would protect from unwanted
> conversions. Additionally, we'll be forced to use a "scoped" name
> instead of "prefixed" one, like symbol_nature::unknown vs
> symbol_nature_unknown, which seems a bit more explicit (will need to
> do something with "static" though, since it's a keyword).
Good point, I'll try this for the new version.
Simon
next prev parent reply other threads:[~2019-08-24 23:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-04 20:10 Simon Marchi
2019-08-04 21:21 ` Tom Tromey
2019-08-05 2:39 ` Simon Marchi
2019-08-05 4:09 ` Tom Tromey
2019-08-21 19:38 ` Pedro Alves
2019-08-22 0:44 ` Simon Marchi
2019-08-22 23:36 ` Simon Marchi
2019-08-23 15:35 ` Pedro Alves
2019-08-23 19:33 ` Simon Marchi
2019-08-23 19:47 ` Pedro Alves
2019-08-23 19:53 ` Simon Marchi
2019-08-23 20:23 ` Pedro Alves
2019-08-23 22:24 ` Simon Marchi
2019-08-23 22:25 ` Simon Marchi
2019-08-24 11:23 ` Ruslan Kabatsayev
2019-08-24 23:56 ` Simon Marchi [this message]
2019-08-25 22:35 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58b2c8d82f3f42588bc1b75f74e1f453@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=b7.10110111@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox