From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21068 invoked by alias); 24 Aug 2019 23:56:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21057 invoked by uid 89); 24 Aug 2019 23:56:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*u:Webmail X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 24 Aug 2019 23:56:03 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x7ONtuKI013509 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 24 Aug 2019 19:56:01 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x7ONtuKI013509 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1566690961; bh=aRsaKCLfDRRJYfv1mHWCz/1md375xJ5cQfQ8+mUexwc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZtVV0AA3tRwzjER8gGepx4VfeX4RjS/Ky+vZX38tQz/Jkt6DGri8Lr+K/4RBwZyrn TfZR5LTV3U34GL5juwdVMvSfzifrQnsB0VcuHTKkdo0aUvYlw2nz6SX3Ap2khczdeY e+L93uPYk7nmrKTJG5ZUYQ/UgqTWyHoE0pyBM4r8= Received: by simark.ca (Postfix, from userid 112) id 9083D1F344; Sat, 24 Aug 2019 19:55:56 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 9E8C81EBE5; Sat, 24 Aug 2019 19:55:55 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 24 Aug 2019 23:56:00 -0000 From: Simon Marchi To: Ruslan Kabatsayev Cc: Pedro Alves , GDB Patches Subject: Re: [PATCH] Remove some variables in favor of using gdb::optional In-Reply-To: References: <20190804201023.25628-1-simon.marchi@polymtl.ca> <9b1cdf6d-baae-3a5e-c2ea-fcdf124b7a1b@redhat.com> <65a23d93-bf2e-de1a-9052-f6d75832c2a1@polymtl.ca> <697c3e3d-4f75-4fb2-685b-a6fa59c7a2a3@polymtl.ca> <5d2e7548-1303-ba42-6d67-93ab37f6577d@redhat.com> <829ab63c-55b0-07bc-1517-0efe9aeecc95@polymtl.ca> Message-ID: <58b2c8d82f3f42588bc1b75f74e1f453@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00567.txt.bz2 On 2019-08-24 07:22, Ruslan Kabatsayev wrote: > Since GDB uses C++11, and we don't really rely on conversion to int > here, why not use enum class? This would protect from unwanted > conversions. Additionally, we'll be forced to use a "scoped" name > instead of "prefixed" one, like symbol_nature::unknown vs > symbol_nature_unknown, which seems a bit more explicit (will need to > do something with "static" though, since it's a keyword). Good point, I'll try this for the new version. Simon