Re: [patch, rfa] tweak to defaulted_query logic to fix gdb.mi test errors

[Sandra Loosemore <sandra@codesourcery.com>]

On 10/18/2016 02:16 PM, Yao Qi wrote:
> On Tue, Sep 6, 2016 at 2:56 PM, Sandra Loosemore
> <sandra@codesourcery.com> wrote:
>> This patch moves the check for deprecated_query_hook before
>> input-not-from-terminal check in defaulted_query, instead of after it.
>> Presently, the only thing that uses deprecated_query_hook is the MI backend,
>> which uses it to suppress the question entirely, so that the current
>> behavior leads to the situation where nothing is printed when the input is a
>> terminal but there is a message otherwise, which is somewhat odd.
>>
>> The specific problem this patch solves is a testing issue with gdbserver.
>> mi_gdb_target_load says:
>>
>> mi_gdb_test "kill" ".*" ""
>>
>> and if the test harness is not running GDB from a terminal we get:
>>
>
> Can you "set interactive-mode on" in your test?  I read your patch several
> times, I am not sure we need this patch.
>

I'm sorry, but what test are you referring to?  There was no testcase 
included with the patch, and the bug affects a whole bunch of the 
existing gdb.mi testcases.

-Sandra