From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108073 invoked by alias); 18 Oct 2016 20:24:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108053 invoked by uid 89); 18 Oct 2016 20:24:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1149, presently X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Oct 2016 20:24:38 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1bwaw8-00040m-IF from Sandra_Loosemore@mentor.com ; Tue, 18 Oct 2016 13:24:36 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 18 Oct 2016 13:24:33 -0700 Subject: Re: [patch, rfa] tweak to defaulted_query logic to fix gdb.mi test errors To: Yao Qi References: <57CF117B.5040106@codesourcery.com> CC: "gdb-patches@sourceware.org" From: Sandra Loosemore Message-ID: <58068500.2010808@codesourcery.com> Date: Tue, 18 Oct 2016 20:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-SW-Source: 2016-10/txt/msg00521.txt.bz2 On 10/18/2016 02:16 PM, Yao Qi wrote: > On Tue, Sep 6, 2016 at 2:56 PM, Sandra Loosemore > wrote: >> This patch moves the check for deprecated_query_hook before >> input-not-from-terminal check in defaulted_query, instead of after it. >> Presently, the only thing that uses deprecated_query_hook is the MI backend, >> which uses it to suppress the question entirely, so that the current >> behavior leads to the situation where nothing is printed when the input is a >> terminal but there is a message otherwise, which is somewhat odd. >> >> The specific problem this patch solves is a testing issue with gdbserver. >> mi_gdb_target_load says: >> >> mi_gdb_test "kill" ".*" "" >> >> and if the test harness is not running GDB from a terminal we get: >> > > Can you "set interactive-mode on" in your test? I read your patch several > times, I am not sure we need this patch. > I'm sorry, but what test are you referring to? There was no testcase included with the patch, and the bug affects a whole bunch of the existing gdb.mi testcases. -Sandra