Re: [PATCH] Do not define basic_string_view::to_string

[Simon Marchi <simark@simark.ca>]

On 2020-06-29 3:08 p.m., Tom Tromey wrote:
> gdb's copy of basic_string_view includes a to_string method.  However,
> according to cppreference, this is not a method on the real
> std::basic_string_view:
> 
> https://en.cppreference.com/w/cpp/string/basic_string_view
> 
> This difference matters because gdb_string_view.h will use the
> standard implementation when built with a C++17 or later.  This caused
> PR build/26183.
> 
> This patch fixes the problem by changing the method to be a standalone
> helper function, and then rewriting the uses.  Tested by rebuilding
> with a version of GCC that defaults to C++17.
> 
> (Note that the build still is not clean; and also I noticed that the
> libstdc++ string_view forbids the use of nullptr ... I wonder if gdb
> violates that.)
> 
> gdb/ChangeLog
> 2020-06-29  Tom Tromey  <tromey@adacore.com>
> 
> 	PR build/26183:
> 	* ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use
> 	gdb::to_string.
> 
> gdbsupport/ChangeLog
> 2020-06-29  Tom Tromey  <tromey@adacore.com>
> 
> 	PR build/26183:
> 	* gdb_string_view.h (basic_string_view::to_string): Remove.
> 	(gdb::to_string): New function.


Thanks, this LGTM.
Simon