From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 3BF103851C03 for ; Mon, 29 Jun 2020 20:44:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3BF103851C03 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B4A9D1E111; Mon, 29 Jun 2020 16:44:04 -0400 (EDT) Subject: Re: [PATCH] Do not define basic_string_view::to_string To: Tom Tromey , gdb-patches@sourceware.org References: <20200629190810.4758-1-tromey@adacore.com> From: Simon Marchi Message-ID: <57f5e2b0-e1fb-dc9e-0933-40d3cc13d8ed@simark.ca> Date: Mon, 29 Jun 2020 16:44:04 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200629190810.4758-1-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2020 20:44:06 -0000 On 2020-06-29 3:08 p.m., Tom Tromey wrote: > gdb's copy of basic_string_view includes a to_string method. However, > according to cppreference, this is not a method on the real > std::basic_string_view: > > https://en.cppreference.com/w/cpp/string/basic_string_view > > This difference matters because gdb_string_view.h will use the > standard implementation when built with a C++17 or later. This caused > PR build/26183. > > This patch fixes the problem by changing the method to be a standalone > helper function, and then rewriting the uses. Tested by rebuilding > with a version of GCC that defaults to C++17. > > (Note that the build still is not clean; and also I noticed that the > libstdc++ string_view forbids the use of nullptr ... I wonder if gdb > violates that.) > > gdb/ChangeLog > 2020-06-29 Tom Tromey > > PR build/26183: > * ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use > gdb::to_string. > > gdbsupport/ChangeLog > 2020-06-29 Tom Tromey > > PR build/26183: > * gdb_string_view.h (basic_string_view::to_string): Remove. > (gdb::to_string): New function. Thanks, this LGTM. Simon