Re: [PATCH][gdb/testsuite] Add have_mpx in lib/gdb.exp

[Tom de Vries <tdevries@suse.de>]

On 1/12/21 4:35 PM, Simon Marchi wrote:
> On 2021-01-12 5:59 a.m., Tom de Vries wrote:
>> +    set compile_flags "incdir=${srcdir}/.."
>> +    if {![gdb_simple_compile $me $src executable $compile_flags]} {
>> +        return 0
>> +    }
>> +
>> +    set result [remote_exec target $obj]
>> +    set status [lindex $result 0]
>> +    set output [lindex $result 1]
>> +    if { $output != "" } {
>> +	return 0
>> +    }
>> +
>> +    remote_file build delete $obj
> 
> 
> Should we delete the obj file in the `if { $output != "" }`?
> 

Yes, thanks for catching that.  Fixed and committed.

> When is that path taken?
> 

When the executable produces some output, which it shouldn't.

Thanks,
- Tom

> Otherwise, that LGTM.
> 
> Simon
>