From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-bounces@sourceware.org>
Received: from simark.ca
	by simark.ca with LMTP
	id 2KdKMLTQ/V8ISQAAWB0awg
	(envelope-from <gdb-patches-bounces@sourceware.org>)
	for <public-inbox@simark.ca>; Tue, 12 Jan 2021 11:39:16 -0500
Received: by simark.ca (Postfix, from userid 112)
	id C3EBD1EF7E; Tue, 12 Jan 2021 11:39:16 -0500 (EST)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca
X-Spam-Level: 
X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE
	autolearn=no autolearn_force=no version=3.4.2
Received: from sourceware.org (unknown [8.43.85.97])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPS id 816DB1EE1B
	for <public-inbox@simark.ca>; Tue, 12 Jan 2021 11:39:16 -0500 (EST)
Received: from server2.sourceware.org (localhost [IPv6:::1])
	by sourceware.org (Postfix) with ESMTP id E8CCE386F439;
	Tue, 12 Jan 2021 16:39:15 +0000 (GMT)
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by sourceware.org (Postfix) with ESMTPS id D221B386F439
 for <gdb-patches@sourceware.org>; Tue, 12 Jan 2021 16:39:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D221B386F439
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
 by mx2.suse.de (Postfix) with ESMTP id E1112ACE1;
 Tue, 12 Jan 2021 16:39:09 +0000 (UTC)
Subject: Re: [PATCH][gdb/testsuite] Add have_mpx in lib/gdb.exp
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20210112105917.GA7254@delia>
 <678bd91e-5b59-657c-a544-cfe7ce682eff@polymtl.ca>
From: Tom de Vries <tdevries@suse.de>
Message-ID: <5786ed3d-1317-0b4f-9a86-c57974431705@suse.de>
Date: Tue, 12 Jan 2021 17:39:09 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <678bd91e-5b59-657c-a544-cfe7ce682eff@polymtl.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
Errors-To: gdb-patches-bounces@sourceware.org
Sender: "Gdb-patches" <gdb-patches-bounces@sourceware.org>

On 1/12/21 4:35 PM, Simon Marchi wrote:
> On 2021-01-12 5:59 a.m., Tom de Vries wrote:
>> +    set compile_flags "incdir=${srcdir}/.."
>> +    if {![gdb_simple_compile $me $src executable $compile_flags]} {
>> +        return 0
>> +    }
>> +
>> +    set result [remote_exec target $obj]
>> +    set status [lindex $result 0]
>> +    set output [lindex $result 1]
>> +    if { $output != "" } {
>> +	return 0
>> +    }
>> +
>> +    remote_file build delete $obj
> 
> 
> Should we delete the obj file in the `if { $output != "" }`?
> 

Yes, thanks for catching that.  Fixed and committed.

> When is that path taken?
> 

When the executable produces some output, which it shouldn't.

Thanks,
- Tom

> Otherwise, that LGTM.
> 
> Simon
>