Re: [RFAv2] Fix internal error and improve 'set debug infrun 1'/target wait kind trace

[Tom de Vries <tdevries@suse.de>]

On 01-04-19 21:05, Philippe Waroquiers wrote:
> On Mon, 2019-04-01 at 09:32 -0700, Kevin Buettner wrote:
>>> gdb/ChangeLog
>>> 2019-03-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
>>>
>>> 	* infrun.c (stop_all_threads): If debug_infrun, always
>>> 	trace the wait status after wait_one, using
>>> 	target_waitstatus_to_string and target_pid_to_str.
>>> 	(handle_inferior_event): Replace various trace of
>>> 	wait status kind by a single trace.
>>> 	* gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
>>> 	wait status kind image by target_waitstatus_to_string.
>>> 	* target/waitstatus.c (target_waitstatus_to_string): Fix
>>> 	obsolete comment.
>>
>> Okay.
>>
>> Kevin
> Thanks for the reviews, pushed.

Hi,

I ran today into the failure that this commit fixes:
...
FAIL: gdb.threads/watchthreads-reorder.exp: reorder1: continue to
breakpoint: break-at-exit (GDB internal error)
...
on the 8.3 branch.

My understanding from reading the rationale is that this is sufficiently
cornercase to not merit a backport, but perhaps someone thinks otherwise?

If we decide not to backport, we could perhaps mark this as as KFAIL in
the 8.3 branch?

Thanks,
- Tom