From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53667 invoked by alias); 11 Sep 2019 17:05:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53573 invoked by uid 89); 11 Sep 2019 17:05:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=kevin, Kevin, sk:watchth, HX-Languages-Length:1247 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Sep 2019 17:05:24 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9DB18ACD7; Wed, 11 Sep 2019 17:05:21 +0000 (UTC) Subject: Re: [RFAv2] Fix internal error and improve 'set debug infrun 1'/target wait kind trace To: Philippe Waroquiers , Kevin Buettner , gdb-patches@sourceware.org References: <20190330095831.5616-1-philippe.waroquiers@skynet.be> <20190401093248.615b2c5c@f29-4.lan> <1554145505.1854.7.camel@skynet.be> From: Tom de Vries Openpgp: preference=signencrypt Message-ID: <57392d44-7d10-7009-2f5e-fd790adcbef4@suse.de> Date: Wed, 11 Sep 2019 17:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1554145505.1854.7.camel@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00200.txt.bz2 On 01-04-19 21:05, Philippe Waroquiers wrote: > On Mon, 2019-04-01 at 09:32 -0700, Kevin Buettner wrote: >>> gdb/ChangeLog >>> 2019-03-30 Philippe Waroquiers >>> >>> * infrun.c (stop_all_threads): If debug_infrun, always >>> trace the wait status after wait_one, using >>> target_waitstatus_to_string and target_pid_to_str. >>> (handle_inferior_event): Replace various trace of >>> wait status kind by a single trace. >>> * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local >>> wait status kind image by target_waitstatus_to_string. >>> * target/waitstatus.c (target_waitstatus_to_string): Fix >>> obsolete comment. >> >> Okay. >> >> Kevin > Thanks for the reviews, pushed. Hi, I ran today into the failure that this commit fixes: ... FAIL: gdb.threads/watchthreads-reorder.exp: reorder1: continue to breakpoint: break-at-exit (GDB internal error) ... on the 8.3 branch. My understanding from reading the rationale is that this is sufficiently cornercase to not merit a backport, but perhaps someone thinks otherwise? If we decide not to backport, we could perhaps mark this as as KFAIL in the 8.3 branch? Thanks, - Tom