From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb.ada/minsyms.exp: Don't hardcode the variable's address
Date: Tue, 21 Nov 2017 17:08:00 -0000 [thread overview]
Message-ID: <571c3723-e798-ce6e-ab08-5c0dd8a4ac10@redhat.com> (raw)
In-Reply-To: <20171121165021.53tzinuyifqpcmy3@adacore.com>
On 11/21/2017 04:50 PM, Joel Brobecker wrote:
>> This new testcase has a test that fails like this here:
>>
>> $1 = (<data variable, no debug info> *) 0x60208c <some_minsym>
>> (gdb) FAIL: gdb.ada/minsyms.exp: print &some_minsym
>>
>> The problem is that the testcase hardcodes an expected address for the
>> "some_minsym" variable, which obviously isn't stable.
>>
>> Fix that by expecting $hex instead.
>>
>> gdb/testsuite/ChangeLog:
>> 2017-11-21 Pedro Alves <palves@redhat.com>
>>
>> * gdb.ada/minsyms.exp: Accept any address for 'some_minsym'.
>
> Gaaah. Head-slapping myself on that one.
>
> Thanks for fixing. Obviously OK :).
:-)
I pushed this one in, to get it out of the way.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-11-21 17:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 16:11 [PATCH 0/2] Fix a couple gdb.ada/minsyms.exp problems Pedro Alves
2017-11-21 16:11 ` [PATCH 1/2] gdb.ada/minsyms.exp: Don't hardcode the variable's address Pedro Alves
2017-11-21 16:24 ` Sergio Durigan Junior
2017-11-21 16:50 ` Joel Brobecker
2017-11-21 17:08 ` Pedro Alves [this message]
2017-11-21 16:11 ` [PATCH 2/2] Don't lose language determined from the "main" name (fix gdb.ada/minsyms.exp) Pedro Alves
2017-11-21 16:23 ` Sergio Durigan Junior
2017-11-21 16:42 ` Pedro Alves
2017-11-21 16:53 ` Sergio Durigan Junior
2017-11-21 16:56 ` Pedro Alves
2017-11-21 17:05 ` Pedro Alves
2017-11-21 17:15 ` Sergio Durigan Junior
2017-11-21 17:22 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571c3723-e798-ce6e-ab08-5c0dd8a4ac10@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox