From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-143578-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7538 invoked by alias); 21 Nov 2017 17:08:41 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 7528 invoked by uid 89); 21 Nov 2017 17:08:41 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 17:08:40 +0000
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 81CA96E770;	Tue, 21 Nov 2017 17:08:39 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id DAEE660BE5;	Tue, 21 Nov 2017 17:08:38 +0000 (UTC)
Subject: Re: [PATCH 1/2] gdb.ada/minsyms.exp: Don't hardcode the variable's address
To: Joel Brobecker <brobecker@adacore.com>
References: <1511280661-14725-1-git-send-email-palves@redhat.com> <1511280661-14725-2-git-send-email-palves@redhat.com> <20171121165021.53tzinuyifqpcmy3@adacore.com>
Cc: gdb-patches@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <571c3723-e798-ce6e-ab08-5c0dd8a4ac10@redhat.com>
Date: Tue, 21 Nov 2017 17:08:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20171121165021.53tzinuyifqpcmy3@adacore.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-11/txt/msg00450.txt.bz2

On 11/21/2017 04:50 PM, Joel Brobecker wrote:
>> This new testcase has a test that fails like this here:
>>
>>   $1 = (<data variable, no debug info> *) 0x60208c <some_minsym>
>>   (gdb) FAIL: gdb.ada/minsyms.exp: print &some_minsym
>>
>> The problem is that the testcase hardcodes an expected address for the
>> "some_minsym" variable, which obviously isn't stable.
>>
>> Fix that by expecting $hex instead.
>>
>> gdb/testsuite/ChangeLog:
>> 2017-11-21  Pedro Alves  <palves@redhat.com>
>>
>> 	* gdb.ada/minsyms.exp: Accept any address for 'some_minsym'.
> 
> Gaaah. Head-slapping myself on that one.
> 
> Thanks for fixing. Obviously OK :).

:-)

I pushed this one in, to get it out of the way.

Thanks,
Pedro Alves